Skip to content

[cmd] Turn off strict routability when using testnet cmd#1493

Merged
melekes merged 2 commits intodevelopfrom
testnet-cmd-turnoff-strict-routability
Apr 26, 2018
Merged

[cmd] Turn off strict routability when using testnet cmd#1493
melekes merged 2 commits intodevelopfrom
testnet-cmd-turnoff-strict-routability

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Apr 24, 2018

Refs #1454

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@melekes melekes requested a review from ebuchman as a code owner April 24, 2018 15:19
@melekes melekes requested a review from greg-szabo April 24, 2018 15:19

Example:

cmd --v 4 --o ./output --populate-persistent-peers --starting-ip-address 192.167.10.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the example IP address to "192.168.10.2" instead, please? 167 is routable and the point of the example is that you can add non-routable addresses.

@melekes melekes force-pushed the testnet-cmd-turnoff-strict-routability branch from f2cc579 to 6fbc4ab Compare April 24, 2018 15:26
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #1493 into develop will increase coverage by 0.15%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #1493      +/-   ##
===========================================
+ Coverage    63.71%   63.86%   +0.15%     
===========================================
  Files          102      102              
  Lines         9460     9461       +1     
===========================================
+ Hits          6027     6042      +15     
+ Misses        2870     2859      -11     
+ Partials       563      560       -3
Impacted Files Coverage Δ
cmd/tendermint/commands/testnet.go 19.54% <0%> (-0.23%) ⬇️
consensus/state.go 78.01% <0%> (+0.54%) ⬆️
consensus/reactor.go 74.3% <0%> (+1.44%) ⬆️

@melekes melekes merged commit 0d9004a into develop Apr 26, 2018
@melekes melekes deleted the testnet-cmd-turnoff-strict-routability branch April 26, 2018 14:52
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
tendermint#1493)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
…g (backport tendermint#1493) (tendermint#1495)

* build(deps): Bump pillow from 9.3.0 to 10.0.1 in /scripts/qa/reporting (tendermint#1493)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit c1abe91)

# Conflicts:
#	scripts/qa/reporting/requirements.txt

* Resolve conflicts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
…g (backport tendermint#1493) (tendermint#1496)

* build(deps): Bump pillow from 9.3.0 to 10.0.1 in /scripts/qa/reporting (tendermint#1493)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit c1abe91)

# Conflicts:
#	scripts/qa/reporting/requirements.txt

* Resolve conflicts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants