Conversation
Contributor
ebuchman
commented
Apr 27, 2018
- use MarshalJSONIndent for genesis and priv val (closes Generated priv_validator.json should have line breaks #1506)
- always use two-spaces for indents in strings and JSONIndent
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
…attern (tendermint#1510) * proto: change version suffixes vN -> v1betaN * api: regenerate from .v1betaN protos * Rename import paths to api modules to v1betaN * grpc: fix import path in pruning_service.go * proto: update lint ignore paths Follow the renamed packages. * Update .changelog for ADR-107 versioning changes No new entries created, since the previous unreleased entries describe all the upcoming changes and only need to be updated. * .changelog: Updated proto package name to cometbft The changelog entry was merged into main and needed to be updated for the feature branch where we have renamed the proto packages. * Fix redundant import aliases for api packages * p2p: fix lints and restore formatting * e2e: fix revive lint * Fix sundry golangci lints * exclude goconst lints for test files * types: lint fix, formatting in vote_set.go * state/indexer: string constants for SQL queries --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.