This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Conversation
liamsi
reviewed
Jun 11, 2018
| // in the underlying key-value pairs. | ||
| // The keys are sorted before the proofs are computed. | ||
| func SimpleProofsFromMap(m map[string]Hasher) (rootHash []byte, proofs []*SimpleProof) { | ||
| func SimpleProofsFromMap(m map[string]Hasher) (rootHash []byte, proofs map[string]*SimpleProof, keys []string) { |
Contributor
There was a problem hiding this comment.
What is the reason for returning the keys here too? Aren't they included in the newly returned map?
Contributor
There was a problem hiding this comment.
Ah OK. You need them sorted in the order as they were included and they are sorted using .Sort() again in
go-crypto/merkle/simple_map.go
Line 41 in 9211fe9
liamsi
reviewed
Jun 11, 2018
Contributor
liamsi
left a comment
There was a problem hiding this comment.
This all LGTM! It would be cool to link to the issues that explain why these change is necessary. Then, let's merge it
liamsi
approved these changes
Jun 11, 2018
Contributor
liamsi
left a comment
There was a problem hiding this comment.
OK, this is needed for: cosmos/cosmos-sdk#823
cosmos/cosmos-sdk#840
cosmos/cosmos-sdk#786
liamsi
added a commit
to liamsi/go-crypto
that referenced
this pull request
Jun 12, 2018
� This is the 1st commit message: Release/0.8.0 (tendermint#127) https://github.com/Liamsi/go-crypto/blob/8e31aebe2bc23037b9cc11892f3ec4515bbf5991/CHANGELOG.md#080 fix tests, move encoding to encode_test.go, include an example Ledger integration, WIP Fix testcases, all looks OK Prevent unnecessary signatures, improve error messages Bugfix Update to new Ledger API in progress Update to latest upstream, debugging information � This is the commit message tendermint#2: Clarify function names � This is the commit message tendermint#3: Add ed25519, tests will fail until ed25519 verification fix Implement PubKeyLedgerEd25519 Pin to an upstream revision Remove Ledger ed25519 support, for now Move TODOs to tendermint#114 Move from tmlibs #213 (tendermint#115) * move from tmlibs 213 * expose KVPair, simpleproofsfrommap returns keys update ed25519 address scheme (tendermint#112) make PubKeyEd25519.Address() returns the first 20 bytes of the hash of the raw 32-byte pubkey, no amino required forgot PrivKeyLedgerSecp256k1 version bump (tendermint#128) version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few modifications on merkle. Moved from tendermint/tmlibs#213. Needed for cosmos/cosmos-sdk#1062.
Edit (by @liamsi), this is needed for: