Skip to content
This repository was archived by the owner on Jul 15, 2018. It is now read-only.

use key without hashing, SimpleProofsFromMap returns map#213

Closed
mossid wants to merge 1 commit intodevelopfrom
joon/simple-proof-map-returns-map
Closed

use key without hashing, SimpleProofsFromMap returns map#213
mossid wants to merge 1 commit intodevelopfrom
joon/simple-proof-map-returns-map

Conversation

@mossid
Copy link
Contributor

@mossid mossid commented May 24, 2018

No description provided.

@mossid mossid requested review from ebuchman and melekes as code owners May 24, 2018 03:33
@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #213 into develop will decrease coverage by 0.07%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #213      +/-   ##
===========================================
- Coverage    58.99%   58.91%   -0.08%     
===========================================
  Files           59       59              
  Lines         3687     3690       +3     
===========================================
- Hits          2175     2174       -1     
- Misses        1360     1364       +4     
  Partials       152      152
Impacted Files Coverage Δ
merkle/simple_proof.go 66.66% <0%> (-3.34%) ⬇️
merkle/simple_map.go 71.05% <100%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b72ea...e055e88. Read the comment docs.

@melekes melekes requested a review from jaekwon May 24, 2018 05:58
@ebuchman
Copy link
Contributor

heads up I'm moving this stuff to go-crypto: tendermint/go-crypto#105

Btw @mossid what prompted this ? Is there some reason the keys needed to be hashed in the first place ?

@mossid
Copy link
Contributor Author

mossid commented May 24, 2018

I had to cache SimpleProofs of subtrees of RootMultiStore. With hashing the key, I had to traverse every possible combination to construct the map.

The comment says that it is for blinding the key, but leaf nodes are hashed anyway so paths don't expose keys. @ebuchman

@ebuchman
Copy link
Contributor

ebuchman commented Jun 9, 2018

Moved to tendermint/go-crypto#115

@ebuchman ebuchman closed this Jun 9, 2018
@ebuchman ebuchman deleted the joon/simple-proof-map-returns-map branch June 9, 2018 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants