Skip to content
This repository was archived by the owner on Jul 15, 2018. It is now read-only.

Implement signatures MarshalJSON()#2

Closed
alessio wants to merge 1 commit intotendermint:masterfrom
alessio:master
Closed

Implement signatures MarshalJSON()#2
alessio wants to merge 1 commit intotendermint:masterfrom
alessio:master

Conversation

@alessio
Copy link
Contributor

@alessio alessio commented Dec 20, 2016

Cast signatures to byte slices before calling
json.Marshal().

Fixes #1

@ebuchman
Copy link
Contributor

@alessio and @ethanfrey we can close this now?

@alessio
Copy link
Contributor Author

alessio commented Feb 24, 2017

Yes, we can. Closing now, thanks!

@alessio alessio closed this Feb 24, 2017
liamsi added a commit to liamsi/go-crypto that referenced this pull request Jun 12, 2018
� This is the 1st commit message:

Release/0.8.0 (tendermint#127)

https://github.com/Liamsi/go-crypto/blob/8e31aebe2bc23037b9cc11892f3ec4515bbf5991/CHANGELOG.md#080

fix tests, move encoding to encode_test.go, include an example

Ledger integration, WIP

Fix testcases, all looks OK

Prevent unnecessary signatures, improve error messages

Bugfix

Update to new Ledger API in progress

Update to latest upstream, debugging information

� This is the commit message tendermint#2:

Clarify function names
liamsi added a commit to liamsi/go-crypto that referenced this pull request Jun 12, 2018
� This is the 1st commit message:

Release/0.8.0 (tendermint#127)

https://github.com/Liamsi/go-crypto/blob/8e31aebe2bc23037b9cc11892f3ec4515bbf5991/CHANGELOG.md#080

fix tests, move encoding to encode_test.go, include an example

Ledger integration, WIP

Fix testcases, all looks OK

Prevent unnecessary signatures, improve error messages

Bugfix

Update to new Ledger API in progress

Update to latest upstream, debugging information

� This is the commit message tendermint#2:

Clarify function names

� This is the commit message tendermint#3:

Add ed25519, tests will fail until ed25519 verification fix

Implement PubKeyLedgerEd25519

Pin to an upstream revision

Remove Ledger ed25519 support, for now

Move TODOs to tendermint#114

Move from tmlibs #213 (tendermint#115)

* move from tmlibs 213
* expose KVPair, simpleproofsfrommap returns keys

update ed25519 address scheme (tendermint#112)

make PubKeyEd25519.Address() returns the first 20 bytes of the hash of the raw 32-byte pubkey, no amino required

forgot PrivKeyLedgerSecp256k1

version bump (tendermint#128)

version bump
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants