Fix more 402 Temporal tests broken by ICU72/CLDR42#3762
Merged
Conversation
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jan 10, 2023
Updates Test262 to include tc39/test262#3762. Also adds additional tests to our codecov test run.
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jan 10, 2023
* Updates GH actions to latest versions * Uses Node19 for all actions and tests * Updates @js-temporal/temporal-test262-runner lib to run more tests that were missed by the previous runner version * Updates Test262 to include tc39/test262#3762 so that additional tests run by the new runner will pass. * Adds those newly-run, newly-passing tests to the codecov test script.
ptomato
approved these changes
Jan 10, 2023
Contributor
There was a problem hiding this comment.
Thanks for catching and fixing these!
I'll merge this right away in order to fix the breakage, but I think we can probably improve these tests more in the future. I'll write down my notes here so I can find them later:
- The point of the tests is that the formatter gives the same date as the PlainDateTime despite the formatter being constructed with a time zone with a large offset.
- Probably it'd be sufficient to ensure that the correct numbers were in the string.
- For
formatToParts/formatRangeToParts, we can verify this directly. - For
format/formatRange, maybe asserting something likeresult.includes('8/4/2021')or comparing with a regexp/8[^0-9]+4[^0-9]+2021/
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jan 10, 2023
* Updates GH actions to latest versions * Uses Node19 for all actions and tests * Updates @js-temporal/temporal-test262-runner lib to run more tests that were missed by the previous runner version * Updates Test262 to include tc39/test262#3762 so that additional tests run by the new runner will pass. * Adds those newly-run, newly-passing tests to the codecov test script.
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jan 10, 2023
* Updates GH actions to latest versions * Uses Node19 for all actions and tests * Updates @js-temporal/temporal-test262-runner lib * Adds all DateTimeFormat Test262 tests (because the Temporal polyfill replaces that class) to the CI codecov script. * Updates Test262 to include tc39/test262#3762 so that additional DateTimeFormat tests will pass.
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jan 11, 2023
* Updates GH actions to latest versions * Uses Node19 for all actions and tests * Updates @js-temporal/temporal-test262-runner lib * Includes a few Temporal-related DateTimeFormat Test262 tests to the CI codecov script. * Updates Test262 to include tc39/test262#3762 so that additional DateTimeFormat tests will pass.
justingrant
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Jan 11, 2023
* Updates GH actions to latest versions * Uses Node19 for all actions and tests * Updates @js-temporal/temporal-test262-runner lib * Includes a few Temporal-related DateTimeFormat Test262 tests to the CI codecov script. * Updates Test262 to include tc39/test262#3762 so that additional DateTimeFormat tests will pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4 more Temporal-related tests that break in ICU 72 / CLDR 42.
Follows up on #3676 (comment) and #3751.