Skip to content

Update expected results for CLDR 42#3676

Merged
Ms2ger merged 1 commit into
tc39:mainfrom
anba:cldr42
Nov 29, 2022
Merged

Update expected results for CLDR 42#3676
Ms2ger merged 1 commit into
tc39:mainfrom
anba:cldr42

Conversation

@anba

@anba anba commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Draft until CLDR 42 is published.

ptomato
ptomato reviewed Sep 27, 2022
View reviewed changes

@ptomato ptomato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable for when the time comes. Do you have any link explaining the changes? I couldn't find anything about this in the draft CLDR 42 Release Notes

@anba

anba commented Sep 27, 2022

Copy link
Copy Markdown
Contributor Author

I think the changes are from https://unicode-org.atlassian.net/browse/CLDR-14032.

@trflynn89 trflynn89 mentioned this pull request Oct 19, 2022
Merged
@anba anba mentioned this pull request Nov 3, 2022
Closed
@FrankYFTang

FrankYFTang commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Notice also the expectation in the following tests also need to be change to sync with ICU72

  'intl402/DateTimeFormat/prototype/formatRange/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/format/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/Temporal/PlainDateTime/prototype/toLocaleString/resolved-time-zone': [FAIL],
  'intl402/Temporal/PlainTime/prototype/toLocaleString/resolved-time-zone': [FAIL],
  'staging/Intl402/Temporal/old/time-toLocaleString': [FAIL],

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 23, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
50c332d 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 23, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
714f638 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 24, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
b40bfc6 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 24, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
04495e8 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 24, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
d8ead23 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 28, 2022
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
682efdf 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
@FrankYFTang

FrankYFTang commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

CLDR 42 is now published
see https://cldr.unicode.org/index/downloads/cldr-42 could we merge this PR ASAP?

@romulocintra

romulocintra commented Nov 29, 2022

Copy link
Copy Markdown
Member

CLDR 42 is now published see https://cldr.unicode.org/index/downloads/cldr-42 could we merge this PR ASAP?

@ptomato @Ms2ger

@Ms2ger Ms2ger marked this pull request as ready for review November 29, 2022 10:55
@Ms2ger Ms2ger requested a review from a team as a code owner November 29, 2022 10:55
@Ms2ger Ms2ger enabled auto-merge (rebase) November 29, 2022 10:55
@Ms2ger Ms2ger merged commit 7988e3e into tc39:main Nov 29, 2022
@ptomato ptomato mentioned this pull request Dec 17, 2022
Open
@justingrant

justingrant commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Notice also the expectation in the following tests also need to be change to sync with ICU72

  'intl402/DateTimeFormat/prototype/formatRange/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/format/temporal-objects-resolved-time-zone': [FAIL],
  'intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-resolved-time-zone': [FAIL],

@FrankYFTang - I couldn't find these 4 tests in current Test262. Do you know where I can find them? I'm asking to make sure that they're included in glob patterns that are recognized by https://github.com/js-temporal/temporal-test262-runner/blob/main/index.mjs.

@FrankYFTang

FrankYFTang commented Jan 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@FrankYFTang - I couldn't find these 4 tests in current Test262. Do you know where I can find them?

Here-

https://github.com/tc39/test262/blob/main/test/intl402/DateTimeFormat/prototype/formatRange/temporal-objects-resolved-time-zone.js
https://github.com/tc39/test262/blob/main/test/intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-resolved-time-zone.js
https://github.com/tc39/test262/blob/main/test/intl402/DateTimeFormat/prototype/format/temporal-objects-resolved-time-zone.js
https://github.com/tc39/test262/blob/main/test/intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-resolved-time-zone.js

justingrant added a commit to justingrant/test262 that referenced this pull request Jan 10, 2023
@justingrant
Fix more 402 Temporal tests broken by ICU72/CLDR42
2bd5c01 
Fixes 4 more Temporal-related tests that break in ICU 72 / CLDR 42.

Follows up on tc39#3676 and
tc39#3751.
@justingrant justingrant mentioned this pull request Jan 10, 2023
Merged
@justingrant

justingrant commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @FrankYFTang for the links. I just filed #3762 to fix those tests in CLDR 42. I believe that the others were already fixed by #3751.

ptomato pushed a commit that referenced this pull request Jan 10, 2023
@justingrant @ptomato
Fix more 402 Temporal tests broken by ICU72/CLDR42
2c599b0 
Fixes 4 more Temporal-related tests that break in ICU 72 / CLDR 42.

Follows up on #3676 and
#3751.
@anba anba deleted the cldr42 branch September 28, 2023 12:34
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
ba88e1b 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
69e9307 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@anba
Bug 1792775 - Part 14: Temporarily disable some test262 tests. r=dminor
32a0024 
Temporarily disable some test262 tests which no longer produce the expected
results when using CLDR 42 resp. Unicode 15. We can re-enable those tests when
we next update test262 and the following PRs are all merged upstream:
- tc39/test262#3662
- tc39/test262#3663
- tc39/test262#3676

Differential Revision: https://phabricator.services.mozilla.com/D160192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptomato ptomato ptomato left review comments

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees

No one assigned

Labels

awaiting specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anba @FrankYFTang @romulocintra @justingrant @Ms2ger @ptomato