Support running Temporal tests in Node 19 (cont'd for staging tests)#3751
Merged
Conversation
d6ad4e1 to
8c1f899
Compare
gibson042
requested changes
Dec 13, 2022
b84bd27 to
f29267b
Compare
fca9c2c to
ceb4232
Compare
Contributor
Author
|
@gibson042 - I made the changes you recommended, rebased to main, and cleaned up commits by running prettier first and then layering my changes on top so the diff will be easier to review. |
gibson042
approved these changes
Dec 16, 2022
31b1bd2 to
eeee385
Compare
741c062 to
00e1205
Compare
Contributor
Author
|
@gibson042 All code review issues should be resolved, but there's been enough change that it may be worth one more review before merging. When reviewing, you'll want to look at each commit individually for easier review. I apologize for all the commit notification spam from this PR. I wasn't able to figure out how to get my local install of Node 19 to use ICU 72 like GH Actions does, so I had to use CI to validate all changes. Grrrrr. |
gibson042
approved these changes
Dec 18, 2022
Make locales consistent throughout these tests, and splitting into a separate commit to make it easier to review substantial changes later.
Adapt to the following changes in CLDR 42 in Node 19: - Some spaces in formats replaced by other whitespace unicode characters - German format changes, which may be bugs (see https://unicode-org.atlassian.net/browse/CLDR-16243) This commit makes affected tests more resilient to Intl.DTF output changes between Node versions. A good idea for a future PR would be to change these tests to rely less on CLDR formats while still testing that Temporal and Intl are behaving as expected.
00e1205 to
cb9fff8
Compare
This was referenced Jan 10, 2023
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #3750, this PR supports running Temporal "staging" tests (https://github.com/tc39/test262/tree/main/test/staging) under Node 19.
For context,
Intl.DateTimeFormatimplementations in Node 19 have ICU format changes:This PR makes affected tests more resilient to
Intl.DateTimeFormatoutput changes between Node versions. They'll continue to work even if the behavior (e.g. in German) turns out to be a bug and is fixed in the platform.