fix: abort navigation after async rendering if obsolete#15811
Merged
Conversation
With async Svelte, rendering itself can take a bit, and during that time a new navigation could occur. We therefore have to check the navigation token once more. We also should only update the props.page once - the duplicative and now-deleted code was pre-`$app/state` and kept around without reason, now being wasteful at best and causing buggy rerenders at worst. Helps with the redirect test not failing anymore against latest Svelte.
🦋 Changeset detectedLatest commit: b744b4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
May 7, 2026
dummdidumm
commented
May 7, 2026
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
May 14, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.60.0 ### Minor Changes - feat: allow 'submit' and 'hidden' form fields to accept numbers and booleans ([#15802](#15802)) - feat: warn on unread `form` remote function validation issues ([#15653](#15653)) ### Patch Changes - fix: abort navigation after async rendering if obsolete ([#15811](#15811)) - fix: skip refreshing queries on full-page reload form submissions ([#15803](#15803)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With async Svelte, rendering itself can take a bit, and during that time a new navigation could occur. We therefore have to check the navigation token once more. We also should only update the props.page once - the duplicative and now-deleted code was pre-
$app/stateand kept around without reason, now being wasteful at best and causing buggy rerenders at worst. Helps with the redirect test not failing anymore against latest Svelte.