feat: allow 'submit' and 'hidden' form fields to accept numbers and booleans#15802
Merged
elliott-with-the-longest-name-on-github merged 4 commits intoMay 11, 2026
Conversation
🦋 Changeset detectedLatest commit: 55de1eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
approved these changes
May 11, 2026
elliott-with-the-longest-name-on-github
left a comment
Contributor
There was a problem hiding this comment.
ty
2549a44
into
sveltejs:main
26 checks passed
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
May 14, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.60.0 ### Minor Changes - feat: allow 'submit' and 'hidden' form fields to accept numbers and booleans ([#15802](#15802)) - feat: warn on unread `form` remote function validation issues ([#15653](#15653)) ### Patch Changes - fix: abort navigation after async rendering if obsolete ([#15811](#15811)) - fix: skip refreshing queries on full-page reload form submissions ([#15803](#15803)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced May 15, 2026
teemingc
added a commit
that referenced
this pull request
May 18, 2026
closes #15840 `.as('hidden', booleanValue)` (added in #15802, shipped in 2.60.0) renders correctly on the client — `<input value="true" name="b:flag">` — but the receive path was missed. `convert_formdata` only recognised the `'on'` literal that checkboxes emit, so the server-side `'true'` was coerced to `false`. The schema validates either way (`v.boolean()` accepts both), so handlers ran silently with the wrong data. `'true'` always corrupts to `false`. `'false'` coincidentally lands as `false`. Number `.as('hidden', n)` is unaffected because `n:` keys go through a separate `parseFloat` branch. The fix is one line in `convert_formdata` — accept both writers of `b:` keys. The added unit test would have caught this had it existed when #15802 landed; the e2e test added there only asserts schema validation (which passes either way). --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
2 tasks
ollema
added a commit
to ollema/skiftesgatan.se
that referenced
this pull request
May 26, 2026
## Summary - Bumps deps (commit c861d37). - Adapts the codebase to API changes that landed in SvelteKit 2.61: - **RemoteForm enhance callback** ([kit#15657](sveltejs/kit#15657)): the callback now receives the form instance directly. The old `form` field on the callback arg is gone; the underlying `HTMLFormElement` is now `element`. Migrated `konto/+page.svelte` (changeName, changeEmail, changePassword) and `admin/[username]/+page.svelte` (updateUserName, updateUserEmail). - **Calendar prop drop**: bits-ui's Calendar no longer accepts the `slotCount` prop. Removed the unused derived value and prop pass in `BookingPage.svelte`. Other SvelteKit changes reviewed but no code changes needed here: - [kit#15779](sveltejs/kit#15779) (isomorphic query caching, `.run` removal): we don't call `.run` anywhere. - [kit#15878](sveltejs/kit#15878) (LiveQuery self-iterability): additive; existing `await live` pattern still works. - [kit#15802](sveltejs/kit#15802) (hidden/submit accept numbers/booleans): no `as('hidden'|'submit')` call sites today. - [kit#15653](sveltejs/kit#15653) (warn on unread validation issues): every form already renders `fields.allIssues()`. ## Test plan - [x] `pnpm check` — 0 errors / 0 warnings - [x] `pnpm test` — 55 unit tests passed, 36 e2e tests passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason not to allow
<input type="hidden">to accept numbers and booleans - this is a big ergonomic improvement for little effort:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits