Skip to content

fix: skip refreshing queries on full-page reload form submissions#15803

Merged
elliott-with-the-longest-name-on-github merged 5 commits into
sveltejs:mainfrom
ottomated:no-refresh-non-enhanced
May 11, 2026
Merged

fix: skip refreshing queries on full-page reload form submissions#15803
elliott-with-the-longest-name-on-github merged 5 commits into
sveltejs:mainfrom
ottomated:no-refresh-non-enhanced

Conversation

@ottomated

Copy link
Copy Markdown
Contributor

If a non-enhanced remote form is submitted, it results in a full-page reload. By the nature of a full-page reload, it's impossible for the form to return refreshed queries to the client. Therefore, because queries should be idempotent, we can simply turn query().refresh() into a no-op if it's a full-page reload.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented May 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b9a9f8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"queries should be idempotent"

immediately writes very... potent? empotent? query for test

thanks, I hate it 😆

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit d3b5257 into sveltejs:main May 11, 2026
26 checks passed
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Rich-Harris pushed a commit that referenced this pull request May 14, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.60.0

### Minor Changes

- feat: allow 'submit' and 'hidden' form fields to accept numbers and
booleans ([#15802](#15802))


- feat: warn on unread `form` remote function validation issues
([#15653](#15653))

### Patch Changes

- fix: abort navigation after async rendering if obsolete
([#15811](#15811))


- fix: skip refreshing queries on full-page reload form submissions
([#15803](#15803))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants