Closed
Conversation
Add flag var lazyConnect to ds config
Add a simple implementation of getRandomValues to the browser context
to get rid of the following warning:
[SECURITY] node-uuid: crypto not usable, falling back to insecure
Math.random()
travis: drop io.js, add Node v4 and v6
Stop caching config files
test: fix security warning
Add two new options `middlewareRootDir` and `componentRootDir` allowing users to load middleware and/or components from a custom place
…ath-configuration Configurable directory for components and middleware Close #171
Globalize Loopback-boot
To avoid port collision when running in Jenkins
Change test cases port to be dynamic
Replace fs.existsSync calls with wrapped fs.statSync Close #204
This should fix build failures on Windows caused by line-ending mismatch.
Normalize line endings to support both LF and CRLF [2.x]
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot.
…odules-2x Fix resolution of middleware modules [2.x]
uses simple regex check to test if a path matches NTFS notation
Fix browser tests on Node.js 0.10
Update translations 2.x backport
Add support for ES6 style async boot scripts
See #252 for details
Do not call callbacks twice in async boot scripts
Ignore js sourcemap files from boot
Add CODEOWNERS to 2.x branch
CODEOWNERS: add zbarbuto
Good bye lehni 2x
Some of our dependencies are no longer supporting pre-4.0 versions of Node.js. As a result, our CI builds are failing on these platforms. This pull request removes 0.10 and 0.12 from our Travis CI build matrix and also adds "engines" field to package.json to tell our internal Jenkins CI to stop testing 0.10 and 0.12 versions too.
Drop support for Node.js versions 0.10 and 0.12
Upgrade lodash from 3.x to 4.x
e8a195e to
97a0636
Compare
nabdelgadir
approved these changes
Mar 22, 2019
b-admike
reviewed
Mar 22, 2019
Member
b-admike
left a comment
There was a problem hiding this comment.
LGTM overall, just have some questions.
| function createContext() { | ||
| var context = { | ||
| // required by browserify | ||
| XMLHttpRequest: function() { throw new Error('not implemented'); }, |
Member
There was a problem hiding this comment.
Is this change also associated with the upgrade?
Member
Author
There was a problem hiding this comment.
Yes. Otherwise, it throws an error - not implemented
| @@ -0,0 +1 @@ | |||
| package-lock=true | |||
Member
There was a problem hiding this comment.
Do we need to enable package-lock here? Is that something we want to do throughout our repos?
Member
Author
There was a problem hiding this comment.
I enabled it to run npm audit.
Member
Author
|
FYI: I'm not sure why this PR shows 63 commits. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade deps to remove
npm auditwarnings.Related issues
Checklist
guide