Ignore js sourcemap files from boot#263
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Whoops. Forget I need to sign it for each individual SL repo I contribute to. |
|
@slnode ok to test |
| function getExcludedExtensions() { | ||
| return { | ||
| '.json': '.json', | ||
| '.map': '.map', |
There was a problem hiding this comment.
Please add a comment explaining that this is a temporary workaround - see #245 (comment)
I think the
.mapentry should be also accompanied by a comment explaining that it's a partial fix for a bigger problem and pointing to #245 (comment)
There was a problem hiding this comment.
Ah, yep, missed that. Cheers.
test/compiler.test.js
Outdated
|
|
||
| expect(instructions.middleware.middleware[0]).have.property( | ||
| 'sourceFile', middleware); | ||
| expect(instructions.middleware.middleware[0]).not.have.property( |
There was a problem hiding this comment.
This second expectation is redundant - if the sourceFile property is set to middleware, then the second expectation will always pass. If sourceFile is not set to middleware, then the first expect will abort the test and this second expectation won't be run at all.
Please remove these two lines (2206-2207).
There was a problem hiding this comment.
Ah, yes, fair point. My goal was to ensure that the map file is definitely never loaded but I missed the index being used. Will remove.
450016f to
3d3609d
Compare
|
Released in |
Description
See discussion from #256 and #245
Related issues
Checklist
guide
cc @bajtos