Skip to content

[BUG] Middleware is loading .js.map of .js#256

Closed
ivanproskuryakov wants to merge 1 commit intostrongloop:masterfrom
ivanproskuryakov:master
Closed

[BUG] Middleware is loading .js.map of .js#256
ivanproskuryakov wants to merge 1 commit intostrongloop:masterfrom
ivanproskuryakov:master

Conversation

@ivanproskuryakov
Copy link
Copy Markdown

@slnode
Copy link
Copy Markdown

slnode commented Jul 26, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link
Copy Markdown

slnode commented Jul 26, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link
Copy Markdown

slnode commented Jul 26, 2017

Can one of the admins verify this patch?

@slnode
Copy link
Copy Markdown

slnode commented Jul 26, 2017

Can one of the admins verify this patch?

@ivanproskuryakov ivanproskuryakov changed the title [BUG] Middleware is loading .js.map typescript maps instead of .js #255 [BUG] Middleware is loading .js.map of .js Jul 26, 2017
@zbarbuto
Copy link
Copy Markdown
Member

zbarbuto commented Aug 7, 2017

@ivanproskuryakov Any chance you could fix the build issues? Would love to use this fix myself.

@ivanproskuryakov
Copy link
Copy Markdown
Author

Hi @zbarbuto, there was a problem with title length thrown by "Commit Linter".
It was adjusted the same day, but I don't know how to rerun the Checks.

@zbarbuto
Copy link
Copy Markdown
Member

zbarbuto commented Aug 7, 2017

Fair enough. I noticed anyway there was an existing pull 245 to fix the issue which has a bunch of discussion on it. Have switched to using a fork until either gets merged. Thanks.

@ivanproskuryakov
Copy link
Copy Markdown
Author

@zbarbuto Hey Zak, shall we merge it?

@slnode
Copy link
Copy Markdown

slnode commented Aug 24, 2017

Can one of the admins verify this patch?

@zbarbuto
Copy link
Copy Markdown
Member

@ivanproskuryakov Not really my call to make as it's not my repo. But see discussion in #245 as to why it may not have been merged already.

@ivanproskuryakov
Copy link
Copy Markdown
Author

@zbarbuto sure, I've seen it. Since it's duplicated, I can close this PR and issue.

@zbarbuto zbarbuto mentioned this pull request Sep 14, 2017
2 tasks
@bajtos
Copy link
Copy Markdown
Member

bajtos commented Sep 14, 2017

Closing as a duplicate of #264.

@bajtos bajtos closed this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants