Skip to content

Ignore source maps in boot#264

Merged
bajtos merged 1 commit intostrongloop:masterfrom
NextFaze:fix/ignore-maps-3
Sep 21, 2017
Merged

Ignore source maps in boot#264
bajtos merged 1 commit intostrongloop:masterfrom
NextFaze:fix/ignore-maps-3

Conversation

@zbarbuto
Copy link
Copy Markdown
Member

Description

Same as #263 but fix for 3.x version

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

cc @bajtos

@slnode
Copy link
Copy Markdown

slnode commented Sep 14, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link
Copy Markdown

slnode commented Sep 14, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link
Copy Markdown

slnode commented Sep 14, 2017

Can one of the admins verify this patch?

@slnode
Copy link
Copy Markdown

slnode commented Sep 14, 2017

Can one of the admins verify this patch?

@bajtos bajtos self-assigned this Sep 14, 2017
@bajtos bajtos self-requested a review September 14, 2017 09:24
@bajtos
Copy link
Copy Markdown
Member

bajtos commented Sep 14, 2017

Let's wait until #263 is landed and then forward-port the final result.

Copy link
Copy Markdown
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zbarbuto, #263 has been landed, could you please update this pull request to match the changes from the 2.x branch?

@zbarbuto
Copy link
Copy Markdown
Member Author

Done deal

@bajtos
Copy link
Copy Markdown
Member

bajtos commented Sep 21, 2017

@slnode ok to test

Copy link
Copy Markdown
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bajtos bajtos merged commit 6e7809d into strongloop:master Sep 21, 2017
@bajtos
Copy link
Copy Markdown
Member

bajtos commented Sep 21, 2017

Landed, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants