Fix resolution of middleware modules [2.x]#222
Merged
davidcheung merged 1 commit into2.xfrom Oct 12, 2016
Merged
Conversation
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot.
Contributor
|
@slnode test please |
1 task
Member
Author
|
Released in |
davidcheung
pushed a commit
that referenced
this pull request
Oct 20, 2016
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot. [forward-port of #222]
davidcheung
pushed a commit
that referenced
this pull request
Oct 26, 2016
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot. [forward-port of #222]
davidcheung
pushed a commit
that referenced
this pull request
Nov 11, 2016
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot. [forward-port of #222]
davidcheung
pushed a commit
that referenced
this pull request
Nov 22, 2016
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot. [forward-port of #222]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the code loading "loopback#errorhandler" (for example) to correctly look up the "loopback" module in node_modules of the bootstrapped application, instead of looking it up in node_modules of loopback-boot.
Note that I am intentionally not including any unit-tests, because setting up a correct directory layout reproducing the problem is too difficult.
@davidcheung please review.
I am intentionally sending the PR against the 2.x branch, please forward-port it to your refactor pull request #181.
cc @kraman This should fix the issue you reported in our chat.
cc @raymondfeng