Conversation
Add a simple implementation of getRandomValues to the browser context
to get rid of the following warning:
[SECURITY] node-uuid: crypto not usable, falling back to insecure
Math.random()
472175b to
5f5e86e
Compare
Contributor
|
@bajtos LGTM We are already skipping the browserify test in loopback-core, so I think there shouldn't be problems. might even be worth it to port this to the loopback-core to replace skipped test? |
Member
Author
Possibly. I'd rather check whether the bug was fixed since the time we left the comment in LoopBack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple implementation of getRandomValues to the browser context to get rid of the following warning:
@davidcheung please review
cc @0candy @gunjpan @richardpringle