Skip to content

Add Pay by Bank as a supported LPM#12880

Merged
amk-stripe merged 7 commits into
masterfrom
revert-12776-revert-12769-add-pay-by-bank-lpm
Apr 20, 2026
Merged

Add Pay by Bank as a supported LPM#12880
amk-stripe merged 7 commits into
masterfrom
revert-12776-revert-12769-add-pay-by-bank-lpm

Conversation

@amk-stripe

@amk-stripe amk-stripe commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reverts #12776 -- we're ready to launch this now! stripe/stripe-ios#6238

Summary

Add Pay by Bank as a supported LPM

Motivation

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-5253

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

Screen_recording_20260325_142409.mp4
Screenshot_20260417_134508

Changelog

  • [ADDED]12880 Added support for Pay by Bank (GA in GB, private preview in EU).

@github-actions

github-actions Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │              compressed              │           uncompressed           
          ├─────────────┬─────────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old         │ new         │ diff     │ old       │ new       │ diff     
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
      dex │     4.5 MiB │     4.5 MiB │   +667 B │   9.7 MiB │   9.7 MiB │   +512 B 
     arsc │     3.6 MiB │     3.6 MiB │   +1 KiB │   3.6 MiB │   3.6 MiB │   +1 KiB 
 manifest │     5.8 KiB │     5.8 KiB │      0 B │  30.8 KiB │  30.8 KiB │      0 B 
      res │ 1,004.2 KiB │ 1,005.8 KiB │ +1.5 KiB │   1.6 MiB │   1.6 MiB │ +2.8 KiB 
   native │     2.7 MiB │     2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
    asset │      25 KiB │      25 KiB │     -5 B │  45.8 KiB │  45.8 KiB │     -5 B 
    other │   244.2 KiB │   244.3 KiB │   +160 B │ 502.4 KiB │ 502.7 KiB │   +328 B 
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
    total │    12.1 MiB │    12.1 MiB │ +3.3 KiB │  18.2 MiB │  18.2 MiB │ +4.6 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 45106 │ 45109 │ +3 (+5 -2) 
   types │ 14223 │ 14224 │ +1 (+1 -0) 
 classes │ 11557 │ 11558 │ +1 (+1 -0) 
 methods │ 63175 │ 63181 │ +6 (+6 -0) 
  fields │ 40867 │ 40871 │ +4 (+8 -4) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  319 │  319 │  0         
 entries │ 7421 │ 7424 │ +3 (+3 -0)
APK 
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  3.6 MiB │   +1 KiB │   3.6 MiB │   +1 KiB │ ∆ resources.arsc                          
    788 B │   +788 B │   1.4 KiB │ +1.4 KiB │ + res/Jq.xml                              
    787 B │   +787 B │   1.4 KiB │ +1.4 KiB │ + res/C7.xml                              
  4.5 MiB │   +667 B │   9.7 MiB │   +512 B │ ∆ classes.dex                             
 58.3 KiB │    +80 B │ 129.4 KiB │   +164 B │ ∆ META-INF/CERT.SF                        
 55.1 KiB │    +80 B │ 129.4 KiB │   +164 B │ ∆ META-INF/MANIFEST.MF                    
  8.9 KiB │     -5 B │   8.8 KiB │     -5 B │ ∆ assets/dexopt/baseline.prof             
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  8.3 MiB │ +3.3 KiB │  13.6 MiB │ +4.6 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   45106 │ 45109 │ +3 (+5 -2) 
  
  + Lth/w0;
  + PayByBank
  + pay_by_bank
  + r8-map-id-dc0566a2730cc593738ea91d0061b0576f8ee773ae6794954d95d3e6e0eb8703
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"dc0566a2730cc593738ea91d0061b0576f8ee773ae6794954d95d3e6e0eb8703","r8-mode":"full","version":"8.13.19"}
  
  - r8-map-id-c480147c48552a87cbf3b193f5b3b3741837b2779f4c98238b386f39bbc64fa4
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"c480147c48552a87cbf3b193f5b3b3741837b2779f4c98238b386f39bbc64fa4","r8-mode":"full","version":"8.13.19"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14223 │ 14224 │ +1 (+1 -0) 
  
  + Lth/w0;
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   63175 │ 63181 │ +6 (+6 -0) 
  
  + th.w0 <clinit>()
  + th.w0 a(boolean) → Set
  + th.w0 b(g0) → boolean
  + th.w0 c() → boolean
  + th.w0 d(g0) → t0
  + th.w0 getType() → i6
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40867 │ 40871 │ +4 (+8 -4) 
  
  + th.b E: b
  + th.p0 c: boolean
  + th.t0 c: boolean
  + th.w0 a: w0
  + th.w0 b: i6
  + vh.i6 Z: i6
  + vh.i6 a0: i6[]
  + vh.i6 b0: b
  
  - th.o0 c: boolean
  - th.s0 c: boolean
  - vh.i6 Z: i6[]
  - vh.i6 a0: b
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   7421 │ 7424 │ +3 (+3 -0) 
  + drawable/stripe_ic_paymentsheet_pm_pay_by_bank
  + drawable/stripe_ic_paymentsheet_pm_pay_by_bank_night
  + string/stripe_paymentsheet_payment_method_pay_by_bank

amk-stripe and others added 2 commits April 14, 2026 09:27
@amk-stripe @claude
Add dark mode icon for Pay by Bank
5f7048e 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@amk-stripe @claude
Replace TestPayByBank with mock network tests
3f14d52 
Remove the instrumentation test that hits real backend and add faster,
more reliable mock network tests in PaymentSheetTest and
PaymentMethodEndToEndTest instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@amk-stripe amk-stripe changed the title Revert "Revert "Add Pay by Bank as a supported LPM"" Add Pay by Bank as a supported LPM Apr 17, 2026
@amk-stripe amk-stripe marked this pull request as ready for review April 17, 2026 21:33
@amk-stripe amk-stripe requested review from a team as code owners April 17, 2026 21:33
@amk-stripe amk-stripe merged commit 4bee4ff into master Apr 20, 2026
22 checks passed
@amk-stripe amk-stripe deleted the revert-12776-revert-12769-add-pay-by-bank-lpm branch April 20, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toluo-stripe toluo-stripe toluo-stripe approved these changes

@jaynewstrom-stripe jaynewstrom-stripe Awaiting requested review from jaynewstrom-stripe jaynewstrom-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amk-stripe @toluo-stripe