Skip to content

Revert "Add Pay by Bank as a supported LPM"#12776

Merged
amk-stripe merged 1 commit into
masterfrom
revert-12769-add-pay-by-bank-lpm
Mar 27, 2026
Merged

Revert "Add Pay by Bank as a supported LPM"#12776
amk-stripe merged 1 commit into
masterfrom
revert-12769-add-pay-by-bank-lpm

Conversation

@amk-stripe

@amk-stripe amk-stripe commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Reverts #12769

LPM team asked us to hold off bc they are blocked on penny testing: https://stripe.slack.com/archives/C047JNAFYBX/p1774539380897719?thread_ts=1774445515.185349&cid=C047JNAFYBX

We can merge this PR again when they're ready

@github-actions

github-actions Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │              compressed              │           uncompressed           
          ├─────────────┬─────────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old         │ new         │ diff     │ old       │ new       │ diff     
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
      dex │     4.5 MiB │     4.5 MiB │    -50 B │   9.7 MiB │   9.7 MiB │   -736 B 
     arsc │     3.6 MiB │     3.6 MiB │   -876 B │   3.6 MiB │   3.6 MiB │   -876 B 
 manifest │     5.8 KiB │     5.8 KiB │      0 B │  30.8 KiB │  30.8 KiB │      0 B 
      res │ 1,005.4 KiB │ 1,004.7 KiB │   -788 B │   1.6 MiB │   1.6 MiB │ -1.4 KiB 
   native │     2.7 MiB │     2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
    asset │      25 KiB │    23.4 KiB │ -1.6 KiB │  45.8 KiB │  44.2 KiB │ -1.6 KiB 
    other │   244.6 KiB │   244.5 KiB │    -98 B │ 504.9 KiB │ 504.7 KiB │   -164 B 
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
    total │    12.1 MiB │    12.1 MiB │ -3.3 KiB │  18.2 MiB │  18.2 MiB │ -4.7 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │   0          
 strings │ 44928 │ 44924 │  -4 (+2 -6)  
   types │ 14187 │ 14185 │  -2 (+0 -2)  
 classes │ 11522 │ 11520 │  -2 (+0 -2)  
 methods │ 63098 │ 63088 │ -10 (+0 -10) 
  fields │ 40763 │ 40758 │  -5 (+5 -10) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  319 │  319 │  0         
 entries │ 7427 │ 7425 │ -2 (+0 -2)
APK 
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  7.3 KiB │ -1.6 KiB │   7.2 KiB │ -1.6 KiB │ ∆ assets/dexopt/baseline.prof             
  3.6 MiB │   -876 B │   3.6 MiB │   -876 B │ ∆ resources.arsc                          
          │   -788 B │           │ -1.4 KiB │ - res/Jq.xml                              
   55 KiB │    -56 B │ 129.3 KiB │    -82 B │ ∆ META-INF/MANIFEST.MF                    
  4.5 MiB │    -50 B │   9.7 MiB │   -736 B │ ∆ classes.dex                             
 58.3 KiB │    -40 B │ 129.4 KiB │    -82 B │ ∆ META-INF/CERT.SF                        
    270 B │     -2 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    709 B │     -1 B │   1.3 KiB │      0 B │ ∆ res/UK.xml                              
  1.1 KiB │     +1 B │   3.3 KiB │      0 B │ ∆ res/nn.xml                              
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  8.3 MiB │ -3.3 KiB │  13.5 MiB │ -4.7 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   44928 │ 44924 │ -4 (+2 -6) 
  
  + r8-map-id-e20efeaacb701e41cc1da56703aec94c072c89682e993a7d74474f12ce4594db
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"e20efeaacb701e41cc1da56703aec94c072c89682e993a7d74474f12ce4594db","r8-mode":"full","version":"8.13.19"}
  
  - Luh/x0;
  - Luh/y0;
  - PayByBank
  - pay_by_bank
  - r8-map-id-8be4cf2d567c0ba66f14b01c71acc06cb4ecb749820f5e30558a28e9305acfe8
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"8be4cf2d567c0ba66f14b01c71acc06cb4ecb749820f5e30558a28e9305acfe8","r8-mode":"full","version":"8.13.19"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14187 │ 14185 │ -2 (+0 -2) 
  
  - Luh/x0;
  - Luh/y0;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   63098 │ 63088 │ -10 (+0 -10) 
  
  - uh.x0 <clinit>()
  - uh.x0 a(boolean) → Set
  - uh.x0 b(g0) → t0
  - uh.x0 c(g0) → boolean
  - uh.x0 d() → boolean
  - uh.x0 getType() → e6
  - uh.y0 <clinit>()
  - uh.y0 <init>(int)
  - uh.y0 i(g0) → g
  - uh.y0 k(g0, p0, o1)
  

FIELDS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   40763 │ 40758 │ -5 (+5 -10) 
  
  + uh.b E: b
  + uh.o0 c: boolean
  + uh.t0 c: boolean
  + wh.e6 a0: e6[]
  + wh.e6 b0: b
  
  - uh.p0 c: boolean
  - uh.u0 c: boolean
  - uh.x0 a: x0
  - uh.x0 b: e6
  - uh.y0 a: int
  - uh.y0 b: y0
  - uh.y0 c: y0
  - wh.e6 a0: e6
  - wh.e6 b0: e6[]
  - wh.e6 c0: b
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   7427 │ 7425 │ -2 (+0 -2) 
  - drawable/stripe_ic_paymentsheet_pm_pay_by_bank
  - string/stripe_paymentsheet_payment_method_pay_by_bank

@amk-stripe amk-stripe marked this pull request as ready for review March 27, 2026 17:06
@amk-stripe amk-stripe requested review from a team as code owners March 27, 2026 17:06
@amk-stripe amk-stripe requested a review from samer-stripe March 27, 2026 17:06
@amk-stripe amk-stripe merged commit 144c0e5 into master Mar 27, 2026
21 checks passed
@amk-stripe amk-stripe deleted the revert-12769-add-pay-by-bank-lpm branch March 27, 2026 21:36
amk-stripe added a commit that referenced this pull request Apr 13, 2026
@amk-stripe
Revert "Revert "Add Pay by Bank as a supported LPM (#12769)" (#12776)"
a31af37 
This reverts commit 144c0e5.
@amk-stripe amk-stripe mentioned this pull request Apr 13, 2026
Merged
3 tasks
amk-stripe added a commit that referenced this pull request Apr 20, 2026
@amk-stripe @claude
Add Pay by Bank as a supported LPM (#12880)
4bee4ff 
* Revert "Revert "Add Pay by Bank as a supported LPM (#12769)" (#12776)"

This reverts commit 144c0e5.

* Updae changelog

* Add dark mode icon for Pay by Bank

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude

* Replace TestPayByBank with mock network tests

Remove the instrumentation test that hits real backend and add faster,
more reliable mock network tests in PaymentSheetTest and
PaymentMethodEndToEndTest instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude

* clean up pr

* Update CHANGELOG.md

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaynewstrom-stripe jaynewstrom-stripe jaynewstrom-stripe approved these changes

@samer-stripe samer-stripe Awaiting requested review from samer-stripe samer-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amk-stripe @jaynewstrom-stripe