Skip to content

Add Pay by Bank as a supported LPM#12769

Merged
amk-stripe merged 3 commits into
masterfrom
add-pay-by-bank-lpm
Mar 26, 2026
Merged

Add Pay by Bank as a supported LPM#12769
amk-stripe merged 3 commits into
masterfrom
add-pay-by-bank-lpm

Conversation

@amk-stripe

@amk-stripe amk-stripe commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Committed-By-Agent: claude

Summary

Add Pay by Bank as a supported LPM

Motivation

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-5253

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

Screen_recording_20260325_142409.mp4

Changelog

amk-stripe and others added 2 commits March 25, 2026 14:25
@amk-stripe @claude
Add Pay by Bank as a supported LPM
539e5f6 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@amk-stripe @claude
Add changelog entry for Pay by Bank support
79feab7 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@github-actions

github-actions Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │              compressed              │           uncompressed           
          ├─────────────┬─────────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old         │ new         │ diff     │ old       │ new       │ diff     
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
      dex │     4.5 MiB │     4.5 MiB │   -553 B │   9.6 MiB │   9.6 MiB │   +740 B 
     arsc │     3.6 MiB │     3.6 MiB │   +876 B │   3.6 MiB │   3.6 MiB │   +876 B 
 manifest │     5.8 KiB │     5.8 KiB │      0 B │  30.8 KiB │  30.8 KiB │      0 B 
      res │ 1,004.7 KiB │ 1,005.4 KiB │   +788 B │   1.6 MiB │   1.6 MiB │ +1.4 KiB 
   native │     2.7 MiB │     2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
    asset │      25 KiB │      25 KiB │     +5 B │  45.8 KiB │  45.8 KiB │     +5 B 
    other │   244.5 KiB │   244.6 KiB │    +85 B │ 504.7 KiB │ 504.9 KiB │   +164 B 
──────────┼─────────────┼─────────────┼──────────┼───────────┼───────────┼──────────
    total │    12.1 MiB │    12.1 MiB │ +1.2 KiB │  18.2 MiB │  18.2 MiB │ +3.1 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │   0          
 strings │ 44909 │ 44913 │  +4 (+6 -2)  
   types │ 14182 │ 14184 │  +2 (+2 -0)  
 classes │ 11517 │ 11519 │  +2 (+2 -0)  
 methods │ 63075 │ 63085 │ +10 (+10 -0) 
  fields │ 40744 │ 40749 │  +5 (+10 -5) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  319 │  319 │  0         
 entries │ 7425 │ 7427 │ +2 (+2 -0)
APK 
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  3.6 MiB │   +876 B │   3.6 MiB │   +876 B │ ∆ resources.arsc                          
    788 B │   +788 B │   1.4 KiB │ +1.4 KiB │ + res/Jq.xml                              
  4.5 MiB │   -553 B │   9.6 MiB │   +740 B │ ∆ classes.dex                             
   55 KiB │    +48 B │ 129.4 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF                    
 58.3 KiB │    +34 B │ 129.4 KiB │    +82 B │ ∆ META-INF/CERT.SF                        
  8.9 KiB │     +5 B │   8.8 KiB │     +5 B │ ∆ assets/dexopt/baseline.prof             
  1.2 KiB │     +2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    710 B │     +1 B │   1.3 KiB │      0 B │ ∆ res/UK.xml                              
  1.1 KiB │     -1 B │   3.3 KiB │      0 B │ ∆ res/nn.xml                              
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  8.3 MiB │ +1.2 KiB │  13.6 MiB │ +3.1 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   44909 │ 44913 │ +4 (+6 -2) 
  
  + Luh/x0;
  + Luh/y0;
  + PayByBank
  + pay_by_bank
  + r8-map-id-b08bf58a8d447a73b0444940a97c05df6dd8ab6751c24a9f20f0627e29edd969
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"b08bf58a8d447a73b0444940a97c05df6dd8ab6751c24a9f20f0627e29edd969","r8-mode":"full","version":"8.13.19"}
  
  - r8-map-id-72e9ea8949785afbbb996ad1e04388c1a507f93fa402659f8c6f2ce1d3bec6df
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"72e9ea8949785afbbb996ad1e04388c1a507f93fa402659f8c6f2ce1d3bec6df","r8-mode":"full","version":"8.13.19"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14182 │ 14184 │ +2 (+2 -0) 
  
  + Luh/x0;
  + Luh/y0;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   63075 │ 63085 │ +10 (+10 -0) 
  
  + uh.x0 <clinit>()
  + uh.x0 a(boolean) → Set
  + uh.x0 b(g0) → t0
  + uh.x0 c(g0) → boolean
  + uh.x0 d() → boolean
  + uh.x0 getType() → e6
  + uh.y0 <clinit>()
  + uh.y0 <init>(int)
  + uh.y0 i(g0) → g
  + uh.y0 k(g0, p0, o1)
  

FIELDS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   40744 │ 40749 │ +5 (+10 -5) 
  
  + uh.p0 c: boolean
  + uh.u0 c: boolean
  + uh.x0 a: x0
  + uh.x0 b: e6
  + uh.y0 a: int
  + uh.y0 b: y0
  + uh.y0 c: y0
  + wh.e6 a0: e6
  + wh.e6 b0: e6[]
  + wh.e6 c0: b
  
  - uh.b E: b
  - uh.o0 c: boolean
  - uh.t0 c: boolean
  - wh.e6 a0: e6[]
  - wh.e6 b0: b
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   7425 │ 7427 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_pay_by_bank
  + string/stripe_paymentsheet_payment_method_pay_by_bank

@amk-stripe @claude
fix TestPayByBank
2ddc3d7 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@amk-stripe amk-stripe marked this pull request as ready for review March 26, 2026 19:13
@amk-stripe amk-stripe requested review from a team as code owners March 26, 2026 19:13
@amk-stripe amk-stripe merged commit 477f054 into master Mar 26, 2026
21 checks passed
@amk-stripe amk-stripe deleted the add-pay-by-bank-lpm branch March 26, 2026 20:35
amk-stripe added a commit that referenced this pull request Mar 26, 2026
@amk-stripe
Revert "Add Pay by Bank as a supported LPM (#12769)"
5acef74 
This reverts commit 477f054.
@amk-stripe amk-stripe mentioned this pull request Mar 26, 2026
Merged
amk-stripe added a commit that referenced this pull request Mar 27, 2026
@amk-stripe
Revert "Add Pay by Bank as a supported LPM (#12769)" (#12776)
144c0e5 
This reverts commit 477f054.
amk-stripe added a commit that referenced this pull request Apr 13, 2026
@amk-stripe
Revert "Revert "Add Pay by Bank as a supported LPM (#12769)" (#12776)"
a31af37 
This reverts commit 144c0e5.
amk-stripe added a commit that referenced this pull request Apr 20, 2026
@amk-stripe @claude
Add Pay by Bank as a supported LPM (#12880)
4bee4ff 
* Revert "Revert "Add Pay by Bank as a supported LPM (#12769)" (#12776)"

This reverts commit 144c0e5.

* Updae changelog

* Add dark mode icon for Pay by Bank

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude

* Replace TestPayByBank with mock network tests

Remove the instrumentation test that hits real backend and add faster,
more reliable mock network tests in PaymentSheetTest and
PaymentMethodEndToEndTest instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude

* clean up pr

* Update CHANGELOG.md

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaynewstrom-stripe jaynewstrom-stripe jaynewstrom-stripe approved these changes

@tjclawson-stripe tjclawson-stripe Awaiting requested review from tjclawson-stripe tjclawson-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amk-stripe @jaynewstrom-stripe