Skip to content

CryptoOnramp SDK: Add Card + Bank Account Option For Payment Collection#12332

Merged
Twigz merged 2 commits intomasterfrom
twigz/card-and-bank-account-payment
Feb 10, 2026
Merged

CryptoOnramp SDK: Add Card + Bank Account Option For Payment Collection#12332
Twigz merged 2 commits intomasterfrom
twigz/card-and-bank-account-payment

Conversation

@Twigz
Copy link
Collaborator

@Twigz Twigz commented Feb 10, 2026

Summary

Adds the CardAndBankAccount option to the payment method type used by collectPaymentMethod. This allows clients to allow users to select either a card or bank account in the same menu.

Added a new button to the sample app to demonstrate behavior.

Motivation

Improvements from API review.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screenshot_20260210_112049

@Twigz Twigz requested a review from lng-stripe February 10, 2026 16:23
@Twigz Twigz requested review from a team as code owners February 10, 2026 16:24
@github-actions
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.2 MiB │   2.2 MiB │  0 B │   4.5 MiB │   4.5 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 303.5 KiB │ 303.5 KiB │  0 B │ 457.7 KiB │ 457.7 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   6.6 KiB │   6.6 KiB │  0 B │   6.3 KiB │   6.3 KiB │  0 B 
    other │ 107.5 KiB │ 107.5 KiB │ +4 B │ 214.9 KiB │ 214.9 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ +4 B │  25.5 MiB │  25.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21288 │ 21288 │ 0 (+0 -0) 
   types │  6505 │  6505 │ 0 (+0 -0) 
 classes │  5216 │  5216 │ 0 (+0 -0) 
 methods │ 31840 │ 31840 │ 0 (+0 -0) 
  fields │ 18204 │ 18204 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3719 │ 3719 │  0
APK
   compressed    │  uncompressed   │                    
──────────┬──────┼──────────┬──────┤                    
 size     │ diff │ size     │ diff │ path               
──────────┼──────┼──────────┼──────┼────────────────────
 29.4 KiB │ +4 B │ 65.4 KiB │  0 B │ ∆ META-INF/CERT.SF 
──────────┼──────┼──────────┼──────┼────────────────────
 29.4 KiB │ +4 B │ 65.4 KiB │  0 B │ (total)

@Twigz Twigz merged commit 031684c into master Feb 10, 2026
19 checks passed
@Twigz Twigz deleted the twigz/card-and-bank-account-payment branch February 10, 2026 16:49
Pearapps added a commit that referenced this pull request Feb 11, 2026
* Fix Shop Pay logo size (#12310)

* Add `link.account_lookup.complete` analytics event (#12319)

Port the `linkAccountLookupComplete` analytics event from iOS to track
successful Link account lookups. The event is fired after successful
lookups in all three lookup methods: lookupByEmail, lookupByLinkAuthIntent,
and lookupByLinkAuthTokenClientSecret.


Committed-By-Agent: claude

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

* Simplify `TapToAddHelper` & move to view model level (#12318)

* Remove unnecessary spinner while google pay is displayed. (#12315)

* Remove unnecessary spinner while google pay is displayed.

* Explicitly add spinner to link loading state (it was assuming it was shown behind the activity that was resumed).

* Changelog.

* Return canceled result in intent when user presses back on Shop Pay activity (#12313)

* Remove `PaymentMethodCreateParams` in `LinkPaymentDetails.Saved` & rename attributes in `LinkPaymentDetails.New` (#12322)

* Fetch latest Lokalize translations (#12323)

Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com>

* Replace info icon with learn more message (#12291)

* Replace info icon with learn more message

* Fix CHANGELOG (#12324)

* Fix CHANGELOG

* StripeCryptoOnramp: API Review Feedback Part 5 (#12316)

* Switches the PaymentMethodDisplayData from iconRest: Int to Drawable

* Switch to using imageLoader

* Update OnrampInteractorTest.kt

* Adds separate RestrictTo

* Fix PaymentSheet tests

* Linting

* Update LinkController.kt

* Bump version to 22.8.0 (#12326)

* Bump faraday from 2.12.0 to 2.14.1 (#12327)

Bumps [faraday](https://github.com/lostisland/faraday) from 2.12.0 to 2.14.1.
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](lostisland/faraday@v2.12.0...v2.14.1)

---
updated-dependencies:
- dependency-name: faraday
  dependency-version: 2.14.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Generate dokka for 22.8.0 (#12328)

* CryptoOnramp SDK: Add Card + Bank Account Option For Payment Collection (#12332)

* Adds new payment type

* Adds test button

* Remove billing details from afterpay (#12330)

* Remove billing details from afterpay

* Update CHANGELOG.md

* Launch `TapToAddActivity` from `TapToAddHelper` (#12321)

* Remove horizontal mode Android-only A/A experiment (#12320)

Removes OCS_MOBILE_HORIZONTAL_MODE_ANDROID_AA experiment as it is no longer needed. The other horizontal mode experiments (OCS_MOBILE_HORIZONTAL_MODE_AA and OCS_MOBILE_HORIZONTAL_MODE) remain active.


Committed-By-Agent: claude

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

* [Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction  (#11941)

* first attempt center

* Update IDDetectorTransitioner.kt

* little tighter window

* add in flip logic

* [Identity] Live blur/focus & distance feedback during document capture (#11993)

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitionerTest.kt

* closer and further

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitioner.kt

---------

Co-authored-by: Ken Ackerson <ken@lickability.net>

* update copy and such

* Update IDDetectorTransitioner.kt

* remove generic

* update strings

* Update IDDetectorTransitionerTest.kt

* Update CHANGELOG.md

* Update IDDetectorTransitioner.kt

* Update CHANGELOG.md

* Update IDDetectorTransitioner.kt

* run initial lokalise script

* remove reference

* Update IdentityScanState.kt

* Update CHANGELOG.md

---------

Co-authored-by: Ken Ackerson <ken@lickability.net>
Co-authored-by: Luis Vera <luisv@stripe.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: toluo-stripe <toluo@stripe.com>
Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com>
Co-authored-by: Jay Newstrom <jaynewstrom@stripe.com>
Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com>
Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com>
Co-authored-by: Andrew Harrison <Twigz@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick Porter <88012362+porter-stripe@users.noreply.github.com>
Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com>
Co-authored-by: Ken Ackerson <ken@lickability.net>
Co-authored-by: Luis Vera <luisv@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants