Remove billing details from afterpay by porter-stripe · Pull Request #12330 · stripe/stripe-android

porter-stripe · 2026-02-10T05:08:29Z

Summary

Removes the address line for Afterpay by removing it from form_specs.json and defining it's form in the FormFactory. It is required to remove it from FormSpecs, as the server sends down the billing address 1 as a required field.

Motivation

https://stripe.slack.com/archives/C01CY476ESJ/p1770662696984449

Testing

Manually confirmed the change and that we can confirm payments in test mode

Screenshots

Before	After

Changelog

See diff

github-actions · 2026-02-10T05:14:44Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │             compressed             │         uncompressed          
          ├─────────────┬─────────────┬────────┼──────────┬───────────┬────────
 APK      │ old         │ new         │ diff   │ old      │ new       │ diff   
──────────┼─────────────┼─────────────┼────────┼──────────┼───────────┼────────
      dex │       5 MiB │       5 MiB │  -76 B │ 11.1 MiB │  11.1 MiB │    0 B 
     arsc │     3.6 MiB │     3.6 MiB │    0 B │  3.6 MiB │   3.6 MiB │    0 B 
 manifest │     5.7 KiB │     5.7 KiB │    0 B │ 30.2 KiB │  30.2 KiB │    0 B 
      res │ 1,009.4 KiB │ 1,009.4 KiB │    0 B │  1.7 MiB │   1.7 MiB │    0 B 
   native │   949.9 KiB │   949.9 KiB │    0 B │  2.5 MiB │   2.5 MiB │    0 B 
    asset │    27.2 KiB │    27.2 KiB │   -1 B │ 47.8 KiB │  47.8 KiB │    0 B 
    other │   222.5 KiB │   222.4 KiB │  -52 B │  449 KiB │ 448.1 KiB │ -869 B 
──────────┼─────────────┼─────────────┼────────┼──────────┼───────────┼────────
    total │    10.8 MiB │    10.8 MiB │ -129 B │ 19.4 MiB │  19.4 MiB │ -869 B 

         │         raw          │           unique            
         ├───────┬───────┬──────┼───────┬───────┬─────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff        
─────────┼───────┼───────┼──────┼───────┼───────┼─────────────
   files │     2 │     2 │    0 │       │       │             
 strings │ 58822 │ 58823 │   +1 │ 52509 │ 52509 │ 0 (+2 -2)   
   types │ 20792 │ 20792 │    0 │ 17609 │ 17609 │ 0 (+0 -0)   
 classes │ 14773 │ 14773 │    0 │ 14773 │ 14773 │ 0 (+0 -0)   
 methods │ 78671 │ 78671 │    0 │ 73935 │ 73935 │ 0 (+14 -14) 
  fields │ 51589 │ 51589 │    0 │ 49320 │ 49320 │ 0 (+9 -9)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  325 │  325 │  0   
 entries │ 6981 │ 6981 │  0

APK

     compressed     │    uncompressed    │                                       
───────────┬────────┼───────────┬────────┤                                       
 size      │ diff   │ size      │ diff   │ path                                  
───────────┼────────┼───────────┼────────┼───────────────────────────────────────
   4.2 MiB │  -75 B │   9.4 MiB │    0 B │ ∆ classes.dex                         
   3.5 KiB │  -39 B │  27.1 KiB │ -869 B │ ∆ lpms.json                           
  54.8 KiB │   -8 B │ 128.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                
  58.2 KiB │   -6 B │ 128.9 KiB │    0 B │ ∆ META-INF/CERT.SF                    
 782.7 KiB │   -1 B │   1.8 MiB │    0 B │ ∆ classes2.dex                        
     239 B │   -1 B │     101 B │    0 B │ ∆ assets/sentry-debug-meta.properties 
   1.2 KiB │   +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                   
───────────┼────────┼───────────┼────────┼───────────────────────────────────────
   5.1 MiB │ -129 B │  11.4 MiB │ -869 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   52509 │ 52509 │ 0 (+2 -2) 
  
  + r8-map-id-5b9c9c98392ccf9f75ea5e1556fa8eacb3f3f65680bf5bba47a7533af4de41e1
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5b9c9c98392ccf9f75ea5e1556fa8eacb3f3f65680bf5bba47a7533af4de41e1","r8-mode":"full","version":"8.13.17"}
  
  - r8-map-id-f816147eeafdf9d944a3d7ea1d03877370056bd3422e9bffd57499e0d7ae625a
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f816147eeafdf9d944a3d7ea1d03877370056bd3422e9bffd57499e0d7ae625a","r8-mode":"full","version":"8.13.17"}
  

METHODS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   73935 │ 73935 │ 0 (+14 -14) 
  
  + ah.d a(e0) → boolean
  + ah.d b(boolean) → Set
  + ah.d c(e0) → r0
  + ah.d d() → boolean
  + ah.d getType() → d6
  + ah.h <init>(int)
  + ah.h a(e0, c0, List) → g
  + ah.h b(e0, n4) → g
  + ah.h c(e0, n4, a, n0) → List
  + ah.h f(c0, e0, List, boolean) → a
  + ah.h g(c0, e0, List, n0) → List
  + ah.h h(e0, n4, c) → a
  + ah.h i(c0, List) → boolean
  + ah.h k(e0, n4, a) → ArrayList
  
  - ah.d <init>(int)
  - ah.d a(e0, c0, List) → g
  - ah.d b(e0, n4) → g
  - ah.d c(e0, n4, a, n0) → List
  - ah.d f(c0, e0, List, boolean) → a
  - ah.d g(c0, e0, List, n0) → List
  - ah.d h(e0, n4, c) → a
  - ah.d i(c0, List) → boolean
  - ah.d k(e0, n4, a) → ArrayList
  - ah.h a(e0) → boolean
  - ah.h b(boolean) → Set
  - ah.h c(e0) → r0
  - ah.h d() → boolean
  - ah.h getType() → d6
  

FIELDS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   49320 │ 49320 │ 0 (+9 -9) 
  
  + ah.b C: b
  + ah.d a: d
  + ah.d b: d6
  + ah.h a: int
  + ah.h b: h
  + ah.h c: h
  + ah.h d: h
  + ah.h e: h
  + ah.h f: h
  
  - ah.d a: int
  - ah.d b: d
  - ah.d c: d
  - ah.d d: d
  - ah.d e: d
  - ah.d f: d
  - ah.d g: d
  - ah.h a: h
  - ah.h b: d6

* Fix Shop Pay logo size (#12310) * Add `link.account_lookup.complete` analytics event (#12319) Port the `linkAccountLookupComplete` analytics event from iOS to track successful Link account lookups. The event is fired after successful lookups in all three lookup methods: lookupByEmail, lookupByLinkAuthIntent, and lookupByLinkAuthTokenClientSecret. Committed-By-Agent: claude Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Simplify `TapToAddHelper` & move to view model level (#12318) * Remove unnecessary spinner while google pay is displayed. (#12315) * Remove unnecessary spinner while google pay is displayed. * Explicitly add spinner to link loading state (it was assuming it was shown behind the activity that was resumed). * Changelog. * Return canceled result in intent when user presses back on Shop Pay activity (#12313) * Remove `PaymentMethodCreateParams` in `LinkPaymentDetails.Saved` & rename attributes in `LinkPaymentDetails.New` (#12322) * Fetch latest Lokalize translations (#12323) Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com> * Replace info icon with learn more message (#12291) * Replace info icon with learn more message * Fix CHANGELOG (#12324) * Fix CHANGELOG * StripeCryptoOnramp: API Review Feedback Part 5 (#12316) * Switches the PaymentMethodDisplayData from iconRest: Int to Drawable * Switch to using imageLoader * Update OnrampInteractorTest.kt * Adds separate RestrictTo * Fix PaymentSheet tests * Linting * Update LinkController.kt * Bump version to 22.8.0 (#12326) * Bump faraday from 2.12.0 to 2.14.1 (#12327) Bumps [faraday](https://github.com/lostisland/faraday) from 2.12.0 to 2.14.1. - [Release notes](https://github.com/lostisland/faraday/releases) - [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md) - [Commits](lostisland/faraday@v2.12.0...v2.14.1) --- updated-dependencies: - dependency-name: faraday dependency-version: 2.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Generate dokka for 22.8.0 (#12328) * CryptoOnramp SDK: Add Card + Bank Account Option For Payment Collection (#12332) * Adds new payment type * Adds test button * Remove billing details from afterpay (#12330) * Remove billing details from afterpay * Update CHANGELOG.md * Launch `TapToAddActivity` from `TapToAddHelper` (#12321) * Remove horizontal mode Android-only A/A experiment (#12320) Removes OCS_MOBILE_HORIZONTAL_MODE_ANDROID_AA experiment as it is no longer needed. The other horizontal mode experiments (OCS_MOBILE_HORIZONTAL_MODE_AA and OCS_MOBILE_HORIZONTAL_MODE) remain active. Committed-By-Agent: claude Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * [Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction (#11941) * first attempt center * Update IDDetectorTransitioner.kt * little tighter window * add in flip logic * [Identity] Live blur/focus & distance feedback during document capture (#11993) * Update IDDetectorTransitioner.kt * Update IDDetectorTransitionerTest.kt * closer and further * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt --------- Co-authored-by: Ken Ackerson <ken@lickability.net> * update copy and such * Update IDDetectorTransitioner.kt * remove generic * update strings * Update IDDetectorTransitionerTest.kt * Update CHANGELOG.md * Update IDDetectorTransitioner.kt * Update CHANGELOG.md * Update IDDetectorTransitioner.kt * run initial lokalise script * remove reference * Update IdentityScanState.kt * Update CHANGELOG.md --------- Co-authored-by: Ken Ackerson <ken@lickability.net> Co-authored-by: Luis Vera <luisv@stripe.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: toluo-stripe <toluo@stripe.com> Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com> Co-authored-by: Jay Newstrom <jaynewstrom@stripe.com> Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com> Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com> Co-authored-by: Andrew Harrison <Twigz@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Porter <88012362+porter-stripe@users.noreply.github.com> Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> Co-authored-by: Ken Ackerson <ken@lickability.net> Co-authored-by: Luis Vera <luisv@stripe.com>

Remove billing details from afterpay

28b5f70

Update CHANGELOG.md

7757251

porter-stripe marked this pull request as ready for review February 10, 2026 17:59

porter-stripe requested review from a team as code owners February 10, 2026 17:59

porter-stripe requested a review from tjclawson-stripe February 10, 2026 17:59

jaynewstrom-stripe approved these changes Feb 10, 2026

View reviewed changes

porter-stripe merged commit 73e8dc4 into master Feb 10, 2026
24 of 26 checks passed

porter-stripe deleted the porter/remove-afterpay-line1 branch February 10, 2026 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove billing details from afterpay#12330

Remove billing details from afterpay#12330
porter-stripe merged 2 commits intomasterfrom
porter/remove-afterpay-line1

porter-stripe commented Feb 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

porter-stripe commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Testing

Screenshots

Changelog

Uh oh!

github-actions bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

porter-stripe commented Feb 10, 2026 •

edited

Loading

github-actions bot commented Feb 10, 2026 •

edited

Loading