StripeCryptoOnramp: API Review Feedback Part 5#12316
Merged
Conversation
Contributor
|
Diffuse output: APK |
jaynewstrom-stripe
previously approved these changes
Feb 9, 2026
| */ | ||
| @DrawableRes | ||
| val iconRes: Int, | ||
| val imageLoader: suspend () -> Drawable, |
Collaborator
There was a problem hiding this comment.
We probably want a separate restrict to here, as we don't want to expose this publicly.
jaynewstrom-stripe
previously approved these changes
Feb 9, 2026
jaynewstrom-stripe
previously approved these changes
Feb 9, 2026
jaynewstrom-stripe
approved these changes
Feb 9, 2026
Pearapps
added a commit
that referenced
this pull request
Feb 11, 2026
* Fix Shop Pay logo size (#12310) * Add `link.account_lookup.complete` analytics event (#12319) Port the `linkAccountLookupComplete` analytics event from iOS to track successful Link account lookups. The event is fired after successful lookups in all three lookup methods: lookupByEmail, lookupByLinkAuthIntent, and lookupByLinkAuthTokenClientSecret. Committed-By-Agent: claude Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Simplify `TapToAddHelper` & move to view model level (#12318) * Remove unnecessary spinner while google pay is displayed. (#12315) * Remove unnecessary spinner while google pay is displayed. * Explicitly add spinner to link loading state (it was assuming it was shown behind the activity that was resumed). * Changelog. * Return canceled result in intent when user presses back on Shop Pay activity (#12313) * Remove `PaymentMethodCreateParams` in `LinkPaymentDetails.Saved` & rename attributes in `LinkPaymentDetails.New` (#12322) * Fetch latest Lokalize translations (#12323) Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com> * Replace info icon with learn more message (#12291) * Replace info icon with learn more message * Fix CHANGELOG (#12324) * Fix CHANGELOG * StripeCryptoOnramp: API Review Feedback Part 5 (#12316) * Switches the PaymentMethodDisplayData from iconRest: Int to Drawable * Switch to using imageLoader * Update OnrampInteractorTest.kt * Adds separate RestrictTo * Fix PaymentSheet tests * Linting * Update LinkController.kt * Bump version to 22.8.0 (#12326) * Bump faraday from 2.12.0 to 2.14.1 (#12327) Bumps [faraday](https://github.com/lostisland/faraday) from 2.12.0 to 2.14.1. - [Release notes](https://github.com/lostisland/faraday/releases) - [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md) - [Commits](lostisland/faraday@v2.12.0...v2.14.1) --- updated-dependencies: - dependency-name: faraday dependency-version: 2.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Generate dokka for 22.8.0 (#12328) * CryptoOnramp SDK: Add Card + Bank Account Option For Payment Collection (#12332) * Adds new payment type * Adds test button * Remove billing details from afterpay (#12330) * Remove billing details from afterpay * Update CHANGELOG.md * Launch `TapToAddActivity` from `TapToAddHelper` (#12321) * Remove horizontal mode Android-only A/A experiment (#12320) Removes OCS_MOBILE_HORIZONTAL_MODE_ANDROID_AA experiment as it is no longer needed. The other horizontal mode experiments (OCS_MOBILE_HORIZONTAL_MODE_AA and OCS_MOBILE_HORIZONTAL_MODE) remain active. Committed-By-Agent: claude Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * [Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction (#11941) * first attempt center * Update IDDetectorTransitioner.kt * little tighter window * add in flip logic * [Identity] Live blur/focus & distance feedback during document capture (#11993) * Update IDDetectorTransitioner.kt * Update IDDetectorTransitionerTest.kt * closer and further * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt --------- Co-authored-by: Ken Ackerson <ken@lickability.net> * update copy and such * Update IDDetectorTransitioner.kt * remove generic * update strings * Update IDDetectorTransitionerTest.kt * Update CHANGELOG.md * Update IDDetectorTransitioner.kt * Update CHANGELOG.md * Update IDDetectorTransitioner.kt * run initial lokalise script * remove reference * Update IdentityScanState.kt * Update CHANGELOG.md --------- Co-authored-by: Ken Ackerson <ken@lickability.net> Co-authored-by: Luis Vera <luisv@stripe.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: toluo-stripe <toluo@stripe.com> Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com> Co-authored-by: Jay Newstrom <jaynewstrom@stripe.com> Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com> Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com> Co-authored-by: Andrew Harrison <Twigz@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Porter <88012362+porter-stripe@users.noreply.github.com> Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> Co-authored-by: Ken Ackerson <ken@lickability.net> Co-authored-by: Luis Vera <luisv@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates PaymentMethodDisplayData to use imageLoader to allow for more permissive types of images in the future.
Motivation
API review comments led to this change. Originally we were using iconRes for ReactNative support, but we're now using a different method of making that work, which I confirmed by locally deploying this and testing it via the ReactNative library.
Testing