Date and Time test classes #6501
Merged
+215
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @overload | ||
| def get(self, element_type: Literal["date_input"]) -> Sequence[DateInput]: | ||
| ... |
Check notice
Code scanning / CodeQL
Statement has no effect
tconkling
approved these changes
Apr 19, 2023
Comment on lines
1085
to
1089
| def increment(self) -> TimeInput: | ||
| dt = datetime.combine(date.today(), self.value) + timedelta(seconds=self.step) | ||
| return self.set_value(dt.time()) | ||
|
|
||
| def decrement(self) -> TimeInput: |
Contributor
There was a problem hiding this comment.
Can you add docstrings for these? How much do they increment by, and also - do they need to be synchronized with any frontend code? (Like, do we need to make sure that TimeInput.increment here matches the behavior of TimeInput.increment on the frontend, or is that not important?)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 20, 2023
* develop: Dont use constraints file in scheduled builds (streamlit#6470) Reorganize tests from streamlit_test.py (streamlit#6481) Date and Time test classes (streamlit#6501)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final widget implementations for testing framework!