Reorganize tests from streamlit_test.py #6481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is duplicated in lib/tests/streamlit/elements/legacy_altair_test.py line 41
It is duplicated by lib/tests/streamlit/elements/arrow_altair_test.py line 44
It is duplicated by lib/tests/streamlit/elements/legacy_altair_test.py line 125
It is duplicated by lib/tests/streamlit/elements/arrow_altair_test.py line test_arrow_chart_with_x_y
It is duplicated in lib/tests/streamlit/elements/arrow_altair_test.py line 292
It is duplicated by lib/tests/streamlit/elements/arrow_dataframe_test.py line 51
sfc-gh-mnowotka
approved these changes
Apr 18, 2023
lukasmasuch
approved these changes
Apr 19, 2023
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
This seems to me like a reasonable and good restructuring 👍 I'm not sure about the actual reason why all those elements got mixed into a single file. I assume it only grew this way historically, but maybe there is another reason here. Probably best to do another quick check with @tconkling before merging.
Contributor
|
This is a good change - and yeah, |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 20, 2023
* develop: Dont use constraints file in scheduled builds (streamlit#6470) Reorganize tests from streamlit_test.py (streamlit#6481) Date and Time test classes (streamlit#6501)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This file contained tests for many different unrelated components. I have now moved the tests to files consistent with what module is being tested.
This is not related to any project, but I decided to clean it up because due to conflicts in this file, I had to rebase more than once.
Please describe the project or issue background here
What kind of change does this PR introduce?
Chore
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.