Skip to content

Conversation

@sfc-gh-kbregula
Copy link
Contributor

📚 Context

Currently, the constraints files are updated when a new PR is merged into the develop branch.
After merging, the constraints files will be updated by scheduled builds as well, so these files will be updated at least once a day.

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

🧠 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Insert screenshot of your updated UI/code here

Current:

Insert screenshot of existing UI/code here

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References

Does this depend on other work, documents, or tickets?

  • Issue: Closes #XXXX

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-kbregula sfc-gh-kbregula marked this pull request as ready for review April 12, 2023 07:38
@sfc-gh-kbregula sfc-gh-kbregula changed the title Update constraints file for scheduled builds Update constraints file in scheduled builds Apr 12, 2023
@sfc-gh-kbregula sfc-gh-kbregula changed the title Update constraints file in scheduled builds Dont use constraints file in scheduled builds Apr 19, 2023
@sfc-gh-kbregula sfc-gh-kbregula added the security-assessment-completed Security assessment has been completed for PR label Apr 20, 2023
@sfc-gh-kbregula sfc-gh-kbregula merged commit ea8cca9 into develop Apr 20, 2023
tconkling added a commit to tconkling/streamlit that referenced this pull request Apr 20, 2023
* develop:
  Dont use constraints file in scheduled builds (streamlit#6470)
  Reorganize tests from streamlit_test.py (streamlit#6481)
  Date and Time test classes (streamlit#6501)
@sfc-gh-kmcgrady sfc-gh-kmcgrady deleted the scheduled-builds branch October 5, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants