Skip to content

Fix: Broken Nightly Build #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayagbarnes merged 1 commit into from
Apr 6, 2023
Merged

Fix: Broken Nightly Build #6445

mayagbarnes merged 1 commit into from
Apr 6, 2023

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Apr 6, 2023

📚 Context

Changes made as part of this PR to python-versions.yml, specifically the py_constraint job expanded the workflow's necessary permissions. This then broke the Nightly Build workflow (see failure log) - this is intended to fix nightly, with follow-ons likely necessary to the Release Candidate and Release workflows.

  • What kind of change does this PR introduce?
    • Other, please describe: Fix nightly build workflow

@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Apr 6, 2023
@mayagbarnes mayagbarnes marked this pull request as ready for review April 6, 2023 22:49
@mayagbarnes mayagbarnes merged commit 61830a3 into develop Apr 6, 2023
@mayagbarnes mayagbarnes deleted the nightly-perms branch April 6, 2023 23:04
tconkling added a commit that referenced this pull request Apr 7, 2023
@tconkling
Merge branch 'develop' into st-lib
4d7157e 
* develop:
  Pass additional permission in nightly workflow (#6445)
  Release 1.21.0 (#6444)
  Typo (#6438)
  Printed / logged strings papercut fixes (#6391)
  Migrate to pip only and drop pipenv (#6265)
  Fix pillow rectangle generation in test (#6430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmcgrady kmcgrady kmcgrady approved these changes

@vdonato vdonato Awaiting requested review from vdonato

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayagbarnes @kmcgrady