Skip to content

Conversation

@AnOctopus
Copy link
Contributor

Fixing rectangle generation in tests allows us to remove the upper bound on pillow, as I have determined that the failure does not reflect a potential problem in our code, just incidental to the test.

🧠 Description of Changes

  • This is a breaking API change
  • This is a visible (user-facing) change

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

This allows us to remove the upper bound on pillow, as I have determined
that the failure does not reflect a potential problem in our code, just
incidental to the test.
@AnOctopus AnOctopus added the security-assessment-completed Security assessment has been completed for PR label Apr 4, 2023
@AnOctopus AnOctopus merged commit f60ff62 into streamlit:develop Apr 4, 2023
@AnOctopus AnOctopus deleted the chore/unpin-pillow branch April 4, 2023 22:45
kmcgrady pushed a commit that referenced this pull request Apr 6, 2023
This allows us to remove the upper bound on pillow, as I have determined
that the failure does not reflect a potential problem in our code, just
incidental to the test.
kmcgrady added a commit that referenced this pull request Apr 6, 2023
* Up version to 1.21.0

* Move semver to dev dependency, temporarily pin (#6418)

* Temp pin pillow version

Until we have time to investigate the changes that caused tests to
break.

* Fix pillow rectangle generation in test (#6430)

This allows us to remove the upper bound on pillow, as I have determined
that the failure does not reflect a potential problem in our code, just
incidental to the test.

---------

Co-authored-by: Ken McGrady <ken.mcgrady@snowflake.com>
Co-authored-by: Amanda Walker <amanda@amandawalker.io>
tconkling added a commit that referenced this pull request Apr 7, 2023
* develop:
  Pass additional permission in nightly workflow (#6445)
  Release 1.21.0 (#6444)
  Typo (#6438)
  Printed / logged strings papercut fixes (#6391)
  Migrate to pip only and drop pipenv (#6265)
  Fix pillow rectangle generation in test (#6430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants