Skip to content

Printed / logged strings papercut fixes #6391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnOctopus merged 3 commits into from
Apr 6, 2023
Merged

Printed / logged strings papercut fixes #6391

AnOctopus merged 3 commits into from
Apr 6, 2023
+19 −2

Conversation

@AnOctopus
Copy link
Contributor

@AnOctopus AnOctopus commented Mar 29, 2023

Shrinks the widget id prefix to reduce noise in logs, and uses the clean repr in some commonly printed dataclasses to further reduce noise.

📚 Context

  • Bugfix
  • Feature
  • Refactoring
  • Other, please describe:
    debugging QoL improvements

🧠 Description of Changes

  • This is a breaking API change
  • This is a visible (user-facing) change

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

@AnOctopus
Shrink widget id prefix
9b12518 
Make it less noisy in logs. The exact value doesn't really matter.
@AnOctopus
Add clean repr to commonly printed dataclasses
eaa35a2
@AnOctopus AnOctopus added the security-assessment-completed Security assessment has been completed for PR label Mar 29, 2023
@AnOctopus
Add clean repr to session state dataclasses
56dc424 
Doing this in part to kickstart CI, which is stuck due to recent outages.
@AnOctopus AnOctopus merged commit 3a97ef3 into streamlit:develop Apr 6, 2023
@AnOctopus AnOctopus deleted the feat/printed-strings-papercuts branch April 6, 2023 19:06
tconkling added a commit that referenced this pull request Apr 7, 2023
@tconkling
Merge branch 'develop' into st-lib
4d7157e 
* develop:
  Pass additional permission in nightly workflow (#6445)
  Release 1.21.0 (#6444)
  Typo (#6438)
  Printed / logged strings papercut fixes (#6391)
  Migrate to pip only and drop pipenv (#6265)
  Fix pillow rectangle generation in test (#6430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdonato vdonato vdonato approved these changes

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnOctopus @vdonato