Add a new make target to only install build dependencies #5755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kbregula
approved these changes
Nov 24, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 28, 2022
* develop: Improve error message when widgets of different types have the same key (streamlit#5748) Add a new make target to only install build dependencies (streamlit#5755) Fix camera_input flaky test (hopefully) (streamlit#5714) Fix py_snowflake job for Nightly Release (streamlit#5751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Some of our internal Snowpark conda builds of Streamlit ran into some issues installing
pre-commiton the machines that they run on. We really don't need pre-commit at all when building Streamlit (the
code has already gone through CI + code review at that point, so running pre-commit again is redundant),
so we might as well skip installing it completely.
This PR does this by adding a new make target:
make build-deps, which works the same way asmake mini-devel, but intentionally omits thepre-commitinstallation. We also start using this targetin place of
mini-develin thepackageandconda-packagetargets.What kind of change does this PR introduce?