Skip to content

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Nov 22, 2022

📚 Context

py_snowflake job is now being skipped in the nightly - link to run - I believe this is because we need to add the github event schedule to the if check

  • What kind of change does this PR introduce?
    • Bugfix

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes changed the title Change event check criteria Fix py_snowflake job Nov 22, 2022
@mayagbarnes mayagbarnes force-pushed the fix-nightly branch 2 times, most recently from fcddf9e to 8707be1 Compare November 22, 2022 20:22
@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Nov 22, 2022
@mayagbarnes mayagbarnes changed the title Fix py_snowflake job Fix py_snowflake job for Nightly Release Nov 22, 2022
@mayagbarnes mayagbarnes marked this pull request as ready for review November 23, 2022 02:15
@mayagbarnes mayagbarnes merged commit 8130204 into develop Nov 23, 2022
@mayagbarnes mayagbarnes deleted the fix-nightly branch November 23, 2022 04:14
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 28, 2022
* develop:
  Improve error message when widgets of different types have the same key (streamlit#5748)
  Add a new make target to only install build dependencies (streamlit#5755)
  Fix camera_input flaky test (hopefully) (streamlit#5714)
  Fix py_snowflake job for Nightly Release (streamlit#5751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants