Improve error message when widgets of different types have the same key #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajarenc
approved these changes
Nov 24, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 28, 2022
* develop: Improve error message when widgets of different types have the same key (streamlit#5748) Add a new make target to only install build dependencies (streamlit#5755) Fix camera_input flaky test (hopefully) (streamlit#5714) Fix py_snowflake job for Nightly Release (streamlit#5751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
The message that we currently display to users when they give two widgets the same key
assumes that the two widgets have the same type, which is not necessarily the case.
It doesn't seem worth it to do the work (+add more complexity to this code) to include the
widget types in this message given that it should already be pretty easy to find the offending
widgets with the given stacktrace + key, so this PR just changes the message to not mention
the widget type.
What kind of change does this PR introduce?
🧠 Description of Changes
🌐 References
Closes #5715