feat(volume): toJSON now accepts the asBuffer parameter #952
Merged
G-Rath merged 1 commit intostreamich:masterfrom Sep 22, 2023
shorwood:feat/volume-tojson-asbuffer
Merged
feat(volume): toJSON now accepts the asBuffer parameter #952G-Rath merged 1 commit intostreamich:masterfrom shorwood:feat/volume-tojson-asbuffer
toJSON now accepts the asBuffer parameter #952G-Rath merged 1 commit intostreamich:masterfrom
shorwood:feat/volume-tojson-asbuffer
Conversation
`vol.toJSON` can now output the virtual directory structure as a map of `Buffer` if the `asBuffer` parameter is set to `true`. The default behavior is still to output a map of `utf8` strings.
Buffer as volume contenttoJSON now accepts the asBuffer parameter
G-Rath
approved these changes
Sep 22, 2023
Owner
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Review feedback from the #880.
Note that this PR is isolated and does not include #880
Actions
Extended
vol.toJSONso it can now output the virtual directory structure as a map ofBufferif theasBufferparameter is set totrue