feat(volume): now handling Buffer as volume content#880
Merged
G-Rath merged 2 commits intostreamich:masterfrom Sep 25, 2023
shorwood:master
Merged
feat(volume): now handling Buffer as volume content#880G-Rath merged 2 commits intostreamich:masterfrom shorwood:master
Buffer as volume content#880G-Rath merged 2 commits intostreamich:masterfrom
shorwood:master
Conversation
G-Rath
requested changes
Nov 12, 2022
Contributor
Author
|
bump |
G-Rath
requested changes
Feb 10, 2023
Collaborator
G-Rath
left a comment
There was a problem hiding this comment.
You need to apply prettier
Contributor
Author
Done. |
Collaborator
|
@shorwood are you able to rebase this please? |
This commit resolves cases when you want to inject raw binary (`Buffer`) data into your virtual volumes. For example when you want to validate an archive extracts files correctly.
Contributor
Author
Hi, it's done. Sorry for the close/reopen, I had to sync and cherry pick because rebase was taking too long on my PC. I have also taken the opportunity to reword them a bit for better understanding. Awaiting your feedback. |
G-Rath
approved these changes
Sep 22, 2023
G-Rath
approved these changes
Sep 25, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
# [4.5.0](v4.4.0...v4.5.0) (2023-09-25) ### Features * **volume:** `fromJSON` now accepts `Buffer` as volume content ([#880](#880)) ([9c0a6ff](9c0a6ff))
Owner
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Hi ! While trying to inject some
Bufferinto amemfsvolume from thefromJSONmethod, I noticed it creates a virtual folder. I expected the method to acceptBufferas content but I noticed onlystringare "allowed".This PR resolves cases when you want to inject raw binary data into your volumes. For example when you have some test archives to validate.
Actions
I have written a small patch to fix the issue. I tried to make as few changes as possible. It comes with a new test and some adjustments to the documentation.
I hope it's enough for a quick merge. If not, feel free to share adjustments you would like to be done. I'll try to be as reactive as possible.
Best regards,
Stanley.