feat(volume): implement readv and writev#946
Merged
G-Rath merged 8 commits intostreamich:masterfrom Sep 22, 2023
Merged
Conversation
G-Rath
approved these changes
Sep 15, 2023
Contributor
Author
|
@G-Rath Thank you for review! There was a conflict so I updated this PR. Hope you can recheck this 🙂 |
G-Rath
approved these changes
Sep 22, 2023
Owner
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses four missing features (plus two not mentioned there) listed in #735.
readv,writev,readvSyncandwritevSynctoVolume.FileHandle#readvandFileHandle#writev.As a bonus, I modified the existing
readimplementation:readso thatpositioncan receivenull, which better aligns to thereadvsignature. In fact, passingnullwas already working expect that TypeScript complained about that.-1topositionis now equivalent to passingnullfor better compatibility with Node.I also modified the existing
writeimplementation:-1topositionis now equivalent to passingnullfor better compatibility with Node.