Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stenciljs/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.13.0
Choose a base ref
...
head repository: stenciljs/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.14.0
Choose a head ref
  • 10 commits
  • 91 files changed
  • 2 contributors

Commits on Jan 27, 2022

  1. chore(karma): re-enable firefox (#3210)

    Re-add Firefox to the list of target browsers for wider test coverage
    across browsers. 
    
    For now, we target Windows 10 only (like the other browsers). The
    goal of this PR is to get programmatic testing under Firefox in place
    rwaskiewicz authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    c24e792 View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump shelljs from 0.8.4 to 0.8.5 (#3222)

    Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5.
    - [Release notes](https://github.com/shelljs/shelljs/releases)
    - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
    - [Commits](shelljs/shelljs@v0.8.4...v0.8.5)
    
    ---
    updated-dependencies:
    - dependency-name: shelljs
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    30122a0 View commit details
    Browse the repository at this point in the history
  3. chore(deps): bump trim-off-newlines from 1.0.1 to 1.0.3 (#3223)

    Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3.
    - [Release notes](https://github.com/stevemao/trim-off-newlines/releases)
    - [Commits](stevemao/trim-off-newlines@v1.0.1...v1.0.3)
    
    ---
    updated-dependencies:
    - dependency-name: trim-off-newlines
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    5c45164 View commit details
    Browse the repository at this point in the history
  4. chore(deps): bump path-parse from 1.0.6 to 1.0.7 (#3225)

    Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
    - [Release notes](https://github.com/jbgutierrez/path-parse/releases)
    - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)
    
    ---
    updated-dependencies:
    - dependency-name: path-parse
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    80f7513 View commit details
    Browse the repository at this point in the history
  5. feat(typescript): typescript 4.5 support (#3205)

    upgrade typescript to v4.5.4
    
    update client-patch-browser.ts patching of `performance.mark()` &
    `performance.measure()` to be ignored by the type checker. this patch
    allows stencil to support Safari 10; since we don't have access to a
    non-existent performance buffer and changing the return value for either
    of these functions could be considered a breaking chamge, defer altering
    the (non-compliant) functions until stencil drops support for Safari 10
    
    remove non-compliant `window.location.reload()` arguments.
    `reload` has no parameter, although Firefox supports a non-standard
    'forceGet' boolean parameter for bypassing its cache. for all other
    browsers, this is otherwise ignored. these arguments are used in the
    context of stencil's dev-server (IE are only used at dev time). given
    these two statements, the risk of a truly breaking change is deemed
    minimal here
    
    set the return type of `whenDefined` to be
    `Promise<CustomElementConstructor>` over `Promise<void>` to meet new
    type checking expectations with TS v4.4. this leads to a small
    functional change in that the return value for this function when the
    internal registry contains an entry for a given `tagName`, the function
    now returns the constructor associated with the tag name, rather than
    void.
    
    update the function signatures of mock-doc's performance implementation
    by declaring the return type on `mark()` and `measure()` to align with
    the `Performance` interface, but _continue to return undefined_,
    ignoring the type checker errors.
    
    add ts-ignore to handle mock-window & window type diffs
    
    enable `useUnknownInCatchVariables` in all TSConfig files, with the
    exception of the main `tsconfig.json`. Although flipping that bit was
    originally going to be a part of the TS 4.4 upgrade, our decision to
    upgrade from 4.3 -> 4.5 directly increased scope a bit. That and the
    fact there are ~90 places where we want to rework the code, I feel more
    comfortable splitting that off into a separate effort
    
    
    update karma-typescript with monounity/karma-typescript@f4cdc43
    
    update single unit test that was failing following the upgrade.
    
    update typescript import statements that were broken as a result of the
    upgrade to handle `AssertClause`s. move typescript calls to use factory
    methods
    rwaskiewicz authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    806012e View commit details
    Browse the repository at this point in the history
  6. chore(typescript): enable useUnknownInCatchVariables in core (#3211)

    this commit enables the 'useUnknownInCatchVariables' flag in the core
    compiler's tsconfig.json file. the remainder of the changes related
    directly to errors emitted by the TypeScript compiler as a result of
    this change.
    
    the most common change in this commit is updating a `catch` block that
    consists of a single call to stencil's `catchError` function. because
    `catchError` may theoretically accept a value or object that does not
    conform to the `Error` interface, we annotate many of the error
    variables declared in the `catch` block as type `any`, in a good-faith
    effort not to lose any useful information that we would otherwise turn
    into a `Diagnostic`. Using a type guard or other type narrowing
    mechanism would be feasible if any value that is not of type `Error`
    were logged in some other way. However in an attempt to not pollute the
    codebase with two different logging paths, we accept the ambiguity of
    `catchError` and catching errors of type `any`  for the time being.
    rwaskiewicz authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d9f87ac View commit details
    Browse the repository at this point in the history
  7. test(message-utils): add message-utils testing (#3212)

    add testing to `src/util/message-utils.ts#catchError`
    
    fix cases where stencil could print a zero-length string
    rwaskiewicz authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d1d34cc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. chore(jsdoc): document @prop() parsing (#3232)

    this commit adds jsdoc + explicit return types to a portion of the
    codebase that parses Stencil members that are decorated with @prop()
    
    it also includes a minor code change where a duplicated enum is removed
    from a bitwise calculation when determining whether or not a prop's type
    is of the type 'boolean' or not
    rwaskiewicz authored Feb 7, 2022
    Configuration menu
    Copy the full SHA
    7614cba View commit details
    Browse the repository at this point in the history
  2. chore(ionitron): don't mark feature requests as stale (#3234)

    make issues with the label "Feature: Want this? Upvote it!" exempt from
    ionitron marking such issues as stale. it's an acceptable situation
    where we get a totally valid issue/feature request, we mark it as such,
    but it's not the top of the backlog. we should be performing manual
    checks of these for now (although making this smarter in the future to
    look at the number of votes/comments and taking those into account would
    be ideal)
    rwaskiewicz authored Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1c15004 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. 💫 v2.14.0

    rwaskiewicz committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    3a75e1e View commit details
    Browse the repository at this point in the history
Loading