Merged
Conversation
013ec40 to
cadf803
Compare
71972aa to
3833ad9
Compare
ltm
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Firefox is not targeted by our Karma tests
GitHub Issue Number: N/A
What is the new behavior?
Re-add Firefox to the list of target browsers for wider test coverage across browsers. For now, we target Windows 10 only (like the other browsers). The goal of this PR is to get programmatic testing under Firefox in place
Does this introduce a breaking change?
Testing
CI invoked several times to check for flakiness. Unfortunately this is really only going to reveal itself with time if there are flaky tests in Firefox.
Tailed the logs to verify that Firefox tests are actually running
Other information