test(message-utils): add message-utils testing#3212
Merged
rwaskiewicz merged 1 commit intomainfrom Jan 27, 2022
Merged
Conversation
ltm
approved these changes
Jan 25, 2022
src/utils/message-utils.ts
Outdated
| } else { | ||
| if (err.message != null) { | ||
| diagnostic.messageText = err.message.toString(); | ||
| diagnostic.messageText = err.message.length ? err.message.toString() : 'UNKNOWN ERROR'; |
Contributor
There was a problem hiding this comment.
Presumably it's safe to remove toString() since err.message is a string?
Suggested change
| diagnostic.messageText = err.message.length ? err.message.toString() : 'UNKNOWN ERROR'; | |
| diagnostic.messageText = err.message.length ? err.message : 'UNKNOWN ERROR'; |
Member
Author
b88604b to
f223d61
Compare
add testing to src/util/message-utils.ts
e131cca to
a05edec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
There's no unit testing around the message utils we have, which came up in #3211. #3211 did a lot of explicit type annotation around passing
anyinto ourmessage-utils#catchErrormethod, so I figured I'd start there in introducing some tests.GitHub Issue Number: N/A
What is the new behavior?
catchErrorDoes this introduce a breaking change?
Testing
Unit tests were run with coverage to validate we handle the entirety of this method
Other information
Please do not merge, relies on #3211