chore(ionitron): don't mark feature requests as stale#3234
Merged
rwaskiewicz merged 1 commit intomainfrom Feb 7, 2022
Merged
Conversation
make issues with the label "Feature: Want this? Upvote it!" exempt from ionitron marking such issues as stale. it's an acceptable situation where we get a totally valid issue/feature request, we mark it as such, but it's not the top of the backlog. we should be performing manual checks of these for now (although making this smarter in the future to look at the number of votes/comments and taking those into account would be ideal)
ltm
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ionitron can mark issues with the "Feature: Want this? Upvote it!" label as stale
GitHub Issue Number: N/A
What is the new behavior?
make issues with the label "Feature: Want this? Upvote it!" exempt from
ionitron marking such issues as stale. it's an acceptable situation
where we get a totally valid issue/feature request, we mark it as such,
but it's not the top of the backlog. we should be performing manual
checks of these for now (although making this smarter in the future to
look at the number of votes/comments and taking those into account would
be ideal)
Does this introduce a breaking change?
Testing
I didn't test this, although I'm "pretty sure" (famous last words) that I'm using the double quotes properly in this YAML file (since the label contains a colon). The tricky part here is Ionitron marks such issues after 180 days of inactivity, and I don't want to move that value down at the risk of marking more issues accidentally.
Other information
The impetus for this PR is #2648 being marked as stale incorrectly over the weekend.