Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3207 +/- ##
==========================================
- Coverage 57.06% 57.02% -0.05%
==========================================
Files 350 350
Lines 34744 34776 +32
==========================================
+ Hits 19826 19830 +4
- Misses 13269 13298 +29
+ Partials 1649 1648 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e76ab27 to
6f2983e
Compare
dmjb
previously approved these changes
Jan 7, 2026
0909d7c to
6303a20
Compare
6f2983e to
23e6ff0
Compare
jhrozek
previously approved these changes
Jan 8, 2026
The base branch was changed.
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
ca1a387 to
55e7f22
Compare
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
jhrozek
approved these changes
Jan 8, 2026
jerm-dro
added a commit
that referenced
this pull request
Jan 8, 2026
Summary Stacked on #3207 Supports #3125 This PR migrates VMCP spec to use the app config. Changes Delete the old spec field. Add an enabled bit that defaults to false. Configure defaults via kubebuilder annotations. Update documentation, examples, and tests. --------- Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
therealnb
pushed a commit
that referenced
this pull request
Jan 29, 2026
The serviceVersion field in telemetry config is documented as optional with a default of the ToolHive version, but the code was passing empty strings to WithServiceVersion() which requires a non-empty value. This fix applies the default value (from versions.GetVersionInfo().Version) when serviceVersion is omitted, making it truly optional as documented. Fixes error: "service version cannot be empty" when telemetry is enabled without an explicit serviceVersion in the config. Bug was introduced in commit 64eb12e (PR #3207).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3205
Supports #3125
This PR migrates the telemetry config to use the app config's telemetry config.
Changes