Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
=======================================
Coverage 57.02% 57.02%
=======================================
Files 348 348
Lines 34635 34635
=======================================
Hits 19751 19751
Misses 13235 13235
Partials 1649 1649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
reviewed
Jan 7, 2026
Contributor
jhrozek
left a comment
There was a problem hiding this comment.
My only comment is about the breaking change - my gut feeling is that it /should/ be OK to do now, but we should double-check to avoid a bad surprise to our users.
1caf867 to
f26f2c7
Compare
jhrozek
previously approved these changes
Jan 7, 2026
Contributor
jhrozek
left a comment
There was a problem hiding this comment.
acking in case the conflicts can be resolved by re-homing the branch
Base automatically changed from
jerm/2026-01-06-add-vmcp-config-to-spec
to
main
January 7, 2026 22:31
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
0909d7c to
6303a20
Compare
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
jhrozek
approved these changes
Jan 8, 2026
2 tasks
jerm-dro
added a commit
to stacklok/docs-website
that referenced
this pull request
Jan 8, 2026
This change stacklok/toolhive#3205 on the toolhive side modified the shape of the virtual mcp server config. Update VirtualMCPServer documentation to reflect the change.
jerm-dro
added a commit
that referenced
this pull request
Jan 8, 2026
Summary Stacked on #3205 Supports #3125 This PR migrates the telemetry config to use the app config's telemetry config. Changes Delete the legacy telemetry config field on the spec. Preserve the existing application of defaults and normalization of config by converting back into the legacy type. This code is more involved to refactor, so I'm leaving it in place until the refactor is complete. Update docs and examples. --------- Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3203
This migrates the group spec field to use the config data.
Supports #3125
Changes