Skip to content

vmcp: migrate audit config#3208

Merged
jerm-dro merged 5 commits intomainfrom
jerm/2026-01-06-migrate-audit
Jan 8, 2026
Merged

vmcp: migrate audit config#3208
jerm-dro merged 5 commits intomainfrom
jerm/2026-01-06-migrate-audit

Conversation

@jerm-dro
Copy link
Copy Markdown
Contributor

@jerm-dro jerm-dro commented Jan 6, 2026

Summary

Stacked on #3207
Supports #3125

This PR migrates VMCP spec to use the app config.

Changes

  1. Delete the old spec field.
  2. Add an enabled bit that defaults to false.
  3. Configure defaults via kubebuilder annotations.
  4. Update documentation, examples, and tests.

@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Jan 6, 2026
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-audit branch from 7d0a155 to 8c9853d Compare January 6, 2026 21:56
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from e76ab27 to 6f2983e Compare January 6, 2026 21:56
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 6, 2026
@jerm-dro jerm-dro requested review from JAORMX, jhrozek and yrobla January 6, 2026 22:20
@jerm-dro jerm-dro marked this pull request as ready for review January 6, 2026 22:20
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.02%. Comparing base (64eb12e) to head (6c6fd05).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/thv-operator/pkg/vmcpconfig/converter.go 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
- Coverage   57.03%   57.02%   -0.01%     
==========================================
  Files         350      349       -1     
  Lines       34776    34773       -3     
==========================================
- Hits        19833    19829       -4     
+ Misses      13295    13294       -1     
- Partials     1648     1650       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmjb
dmjb previously approved these changes Jan 7, 2026
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from 6f2983e to 23e6ff0 Compare January 7, 2026 22:48
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-audit branch from 4e2ef4a to 4d2e496 Compare January 7, 2026 22:54
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 7, 2026
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from ca1a387 to 55e7f22 Compare January 8, 2026 16:08
Base automatically changed from jerm/2026-01-06-migrate-telemetry to main January 8, 2026 20:24
@jerm-dro jerm-dro dismissed dmjb’s stale review January 8, 2026 20:24

The base branch was changed.

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-audit branch from 4d2e496 to e366b6c Compare January 8, 2026 20:29
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 8, 2026
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Jan 8, 2026
@jerm-dro jerm-dro requested a review from jhrozek January 8, 2026 20:45
@jerm-dro jerm-dro merged commit 7821186 into main Jan 8, 2026
47 of 48 checks passed
@jerm-dro jerm-dro deleted the jerm/2026-01-06-migrate-audit branch January 8, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants