Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: add comment to Stat implementation explaining why we cast the Path field to []byte#62918

Merged
ggilmore merged 1 commit into
mainfrom
05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte
May 29, 2024
Merged

gitserver: grpc: add comment to Stat implementation explaining why we cast the Path field to []byte#62918
ggilmore merged 1 commit into
mainfrom
05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte

Conversation

@ggilmore

@ggilmore ggilmore commented May 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just adding a comment explaining why we have to re-cast path to a []byte for the error message.

Test plan

N/A - just adding a comment

@cla-bot cla-bot Bot added the cla-signed label May 24, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 24, 2024
This was referenced May 24, 2024
Merged
Merged
Merged
@ggilmore Graphite App

ggilmore commented May 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request May 24, 2024
Merged
@ggilmore ggilmore marked this pull request as ready for review May 24, 2024 21:14
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences branch from 51a7e8b to 61ec65a Compare May 24, 2024 21:17
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch from f632d33 to 47aae5a Compare May 24, 2024 21:17
@graphite-app

graphite-app Bot commented May 27, 2024

Copy link
Copy Markdown

Video gif. An elderly man in suspenders smiles as he holds up two thumbs as if saying good luck. (Added via Giphy)

@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences branch from 61ec65a to 1c8fa59 Compare May 28, 2024 20:00
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch from 47aae5a to 39cbe7f Compare May 28, 2024 20:00
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences branch from 1c8fa59 to 44aa557 Compare May 28, 2024 20:02
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch from 39cbe7f to 2cca197 Compare May 28, 2024 20:02
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences branch from 44aa557 to c15fcdd Compare May 28, 2024 20:25
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch from 2cca197 to 7bcaa47 Compare May 28, 2024 20:25
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences branch from c15fcdd to 294234a Compare May 29, 2024 08:50
Base automatically changed from 05-24-gitserver_grpc_relax_blameauthor_name_field_to_allow_arbitrary_byte_sequences to main May 29, 2024 09:18
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch from 7bcaa47 to 0f62ba0 Compare May 29, 2024 09:19
@ggilmore Graphite App

ggilmore commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 29, 5:19 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 29, 5:48 AM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit a210c77 into main May 29, 2024
@ggilmore ggilmore deleted the 05-24-gitserver_grpc_add_comment_to_stat_implementation_explaining_why_we_cast_the_path_field_to_byte branch May 29, 2024 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger