This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: grpc: Change BlameRequest Path field from string to bytes#62916
Merged
ggilmore merged 1 commit intoMay 29, 2024
Merged
Conversation
Contributor
Author
This was referenced May 24, 2024
This was referenced May 24, 2024
5af5698 to
bfa1d98
Compare
6b8dd77 to
ba79370
Compare
eseliger
approved these changes
May 27, 2024
|
|
bfa1d98 to
4274454
Compare
a5c9f0a to
3e86bb8
Compare
4274454 to
2a27773
Compare
3e86bb8 to
61f1d42
Compare
2a27773 to
ba97103
Compare
Base automatically changed from
05-24-gitserver_grpc_change_filenotfoundpayload_path_field_from_string_to_bytes
to
main
May 29, 2024 08:28
On Unix, file paths can be arbitary byte sequences (apart from NUL and they are '/' delimited). As such, we can't assume utf-8 encoding (which is what the string type in protobuf mandates).
61f1d42 to
cca5b48
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitserver: grpc: Change BlameRequest Path field from string to bytes
On Unix, file paths can be arbitary byte sequences (apart from NUL and they are '/' delimited).
As such, we can't assume utf-8 encoding (which is what the string type in protobuf mandates).
Test plan
CI