Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: change gitserver ReadFileRequest.Path type to bytes from string#62914

Merged
ggilmore merged 1 commit into
mainfrom
05-24-gitserver_grpc_change_gitserver_readfilerequest.path_type_to_bytes_from_string
May 29, 2024
Merged

gitserver: grpc: change gitserver ReadFileRequest.Path type to bytes from string#62914
ggilmore merged 1 commit into
mainfrom
05-24-gitserver_grpc_change_gitserver_readfilerequest.path_type_to_bytes_from_string

Conversation

@ggilmore

@ggilmore ggilmore commented May 24, 2024

Copy link
Copy Markdown
Contributor

Closes #62784

File paths can be any byte sequence (excluding a null). This means that non-utf-8 byte sequences are allowed.

Test plan

CI

@cla-bot cla-bot Bot added the cla-signed label May 24, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 24, 2024
@ggilmore ggilmore changed the title gitserver: grpc: change gitserver ReadFileRequest.Path type to bytes from string gitserver: grpc: Add new ChangedFiles method and replace usage of DiffSymbols May 24, 2024
@ggilmore ggilmore changed the title gitserver: grpc: Add new ChangedFiles method and replace usage of DiffSymbols gitserver: grpc: change gitserver ReadFileRequest.Path type to bytes from string May 24, 2024
@ggilmore ggilmore marked this pull request as ready for review May 24, 2024 20:33
@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_change_gitserver_readfilerequest.path_type_to_bytes_from_string branch from f299e55 to 364ec96 Compare May 24, 2024 21:17
@ggilmore ggilmore requested a review from a team May 24, 2024 21:19
@graphite-app

graphite-app Bot commented May 27, 2024

Copy link
Copy Markdown

TV gif. Steve Irwin the Crocodile Hunter looking down at a body of water, turns around and gives a double thumbs-up, mouthing 'that's good.' (Added via Giphy)

@ggilmore ggilmore force-pushed the 05-24-gitserver_grpc_change_gitserver_readfilerequest.path_type_to_bytes_from_string branch from 364ec96 to 1ab9eaa Compare May 28, 2024 20:25
@ggilmore ggilmore merged commit 4add5e8 into main May 29, 2024
@ggilmore ggilmore deleted the 05-24-gitserver_grpc_change_gitserver_readfilerequest.path_type_to_bytes_from_string branch May 29, 2024 07:45

Copy link
Copy Markdown
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gitserver ReadFileRequest.Path should be bytes

2 participants