This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: grpc: create proto roundtrip tests for GetObject[Request/Response]#62564
Merged
ggilmore merged 1 commit intoMay 11, 2024
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pjlast
approved these changes
May 9, 2024
|
|
eseliger
approved these changes
May 10, 2024
a0303e5 to
713e225
Compare
Base automatically changed from
05-08-gitserver_client_grpc_add_tests_for_getobject
to
main
May 10, 2024 21:40
eabfb1b to
7e51609
Compare
Contributor
Author
Merge activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/60411
We didn't have any round trip tests for the GetCommit request or response type. This PR adds them.
Test plan
New unit tests