Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: grpc: fixup and add tests for GetCommit RPC#62561

Merged
ggilmore merged 1 commit into
mainfrom
05-08-gitserver_grpc_fixup_and_add_tests_for_getcommit_rpc
May 10, 2024
Merged

gitserver: grpc: fixup and add tests for GetCommit RPC#62561
ggilmore merged 1 commit into
mainfrom
05-08-gitserver_grpc_fixup_and_add_tests_for_getcommit_rpc

Conversation

@ggilmore

@ggilmore ggilmore commented May 8, 2024

Copy link
Copy Markdown
Contributor

Part of https://github.com/sourcegraph/sourcegraph/issues/60411

This PR fixes up the GetObject gRPC server method by:

  • Adding unit tests for it since there weren't any before
  • Adding a check to fail early if the repository isn't cloned yet (like all of our other grpc methods do).

Test plan

New unit tests

@cla-bot cla-bot Bot added the cla-signed label May 8, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 8, 2024

ggilmore commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

Comment thread internal/gitserver/v1/gitserver.proto
Comment thread cmd/gitserver/internal/server_grpc.go
Comment thread internal/gitserver/v1/gitserver.proto
@graphite-app

graphite-app Bot commented May 10, 2024

Copy link
Copy Markdown

Excited Pizza GIF (Added via Giphy)

@ggilmore ggilmore merged commit 42abd4d into main May 10, 2024
@ggilmore ggilmore deleted the 05-08-gitserver_grpc_fixup_and_add_tests_for_getcommit_rpc branch May 10, 2024 20:52

Copy link
Copy Markdown
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants