Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: client: grpc: add tests for GetObject#62563

Merged
ggilmore merged 1 commit into
mainfrom
05-08-gitserver_client_grpc_add_tests_for_getobject
May 10, 2024
Merged

gitserver: client: grpc: add tests for GetObject#62563
ggilmore merged 1 commit into
mainfrom
05-08-gitserver_client_grpc_add_tests_for_getobject

Conversation

@ggilmore

@ggilmore ggilmore commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds more tests for the gitserver client GetObject method.

Test plan

New unit tests

@cla-bot cla-bot Bot added the cla-signed label May 8, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 8, 2024
@ggilmore Graphite App

ggilmore commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

This was referenced May 8, 2024
Merged
Merged
@ggilmore ggilmore requested a review from a team May 8, 2024 22:33
@ggilmore ggilmore marked this pull request as ready for review May 8, 2024 22:33
pjlast
pjlast reviewed May 9, 2024
View reviewed changes
Comment thread internal/gitserver/commands_test.go Outdated
@graphite-app

graphite-app Bot commented May 10, 2024

Copy link
Copy Markdown

Celebrity gif. A young Keanu Reeves stands in the rain smiling. He raises up his arm and gives an enthusiastic thumbs up. (Added via Giphy)

Base automatically changed from 05-08-gitserver_grpc_fixup_and_add_tests_for_getcommit_rpc to main May 10, 2024 20:52
@ggilmore ggilmore force-pushed the 05-08-gitserver_client_grpc_add_tests_for_getobject branch from a0303e5 to 713e225 Compare May 10, 2024 20:55
@ggilmore Graphite App

ggilmore commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 10, 4:55 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 10, 4:56 PM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'buildkite/sourcegraph', 'scip-go', 'scip-go (lib)', 'scip-go (monitoring)', 'scip-go (dev/ci/images)').

@ggilmore ggilmore merged commit e1a9d6f into main May 10, 2024
@ggilmore ggilmore deleted the 05-08-gitserver_client_grpc_add_tests_for_getobject branch May 10, 2024 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pjlast pjlast pjlast left review comments

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggilmore @pjlast @eseliger