This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Backend: remove internalClient.ExternalURL#55463
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f9d67fe...cf8f8e7.
|
536c8a7 to
1497948
Compare
eseliger
approved these changes
Aug 1, 2023
Member
There was a problem hiding this comment.
there's cmd/frontend/globals/globals.go::ExternalURL that kinda does exactly what's in here, plus reacts to config changes. Should we move that to out of cmd/frontend and use it in here as well?
Member
Author
There was a problem hiding this comment.
Yes, we should. I think this can all just live in the conf package. It's really just caching the URL parsing.
ggilmore
approved these changes
Aug 2, 2023
70444d9 to
cf8f8e7
Compare
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-55463-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c7ab5860fe7597795bc237b4e1574e948c4ebfd6
# Push it to GitHub
git push --set-upstream origin backport-55463-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1Then, create a pull request where the |
varsanojidan
pushed a commit
that referenced
this pull request
Aug 3, 2023
This removes the `internalClient.ExternalURL` method, which can be replaced with a simple call to `conf.Get()`
davejrt
pushed a commit
that referenced
this pull request
Aug 9, 2023
This removes the `internalClient.ExternalURL` method, which can be replaced with a simple call to `conf.Get()`
13 tasks
camdencheek
added a commit
that referenced
this pull request
Aug 17, 2023
This removes the `internalClient.ExternalURL` method, which can be replaced with a simple call to `conf.Get()`
camdencheek
added a commit
that referenced
this pull request
Aug 17, 2023
* Backend: remove internalClient.SendEmail (#55459) Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC (cherry picked from commit f9d67fe) * gRPC: migrate conf endpoint (#55648) (cherry picked from commit 1dd8601) * Backend: remove internalClient.ExternalURL (#55463) This removes the `internalClient.ExternalURL` method, which can be replaced with a simple call to `conf.Get()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
internalClient.ExternalURLmethod, which can be replaced with a simple call toconf.Get()Test plan
Tested that the links in a code monitor still point to the right external URL