This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Backend: remove internalClient.SendEmail#55459
Merged
Merged
Conversation
a58fd5c to
e7d42b8
Compare
ggilmore
approved these changes
Aug 2, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC (cherry picked from commit f9d67fe)
varsanojidan
pushed a commit
that referenced
this pull request
Aug 3, 2023
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC
davejrt
pushed a commit
that referenced
this pull request
Aug 9, 2023
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC
Contributor
|
@camdencheek I didn't notice this open backport until starting the release, apologies for that. The build failed due to an unused import. Given the context of this PR, I'm going to move ahead without this backport as it appears to be a nice-to-have PR. |
Member
Author
|
@sanderginn not a problem! This was just to make backports easier. Thanks for the ping though, I forgot about this one |
camdencheek
added a commit
that referenced
this pull request
Aug 10, 2023
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC (cherry picked from commit f9d67fe)
13 tasks
camdencheek
added a commit
that referenced
this pull request
Aug 17, 2023
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC (cherry picked from commit f9d67fe)
camdencheek
added a commit
that referenced
this pull request
Aug 17, 2023
* Backend: remove internalClient.SendEmail (#55459) Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC (cherry picked from commit f9d67fe) * gRPC: migrate conf endpoint (#55648) (cherry picked from commit 1dd8601) * Backend: remove internalClient.ExternalURL (#55463) This removes the `internalClient.ExternalURL` method, which can be replaced with a simple call to `conf.Get()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that config can be fetched from all services, there is no need for this internalClient method. One fewer to implement for gRPC
Test plan
Sending a test email still worked fine